Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(behavior_velocity_planner): fix rtc behavior in crosswalk module #1296

Merged
merged 1 commit into from
Jul 11, 2022
Merged

fix(behavior_velocity_planner): fix rtc behavior in crosswalk module #1296

merged 1 commit into from
Jul 11, 2022

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 11, 2022 •
edited
Loading

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota
fix(behavior_velocity_planner): fix rtc behavior in crosswalk module
e2d9ce1 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota mentioned this pull request Jul 11, 2022
Merged
8 tasks
@codecov
Copy link

codecov bot commented Jul 11, 2022 •
edited
Loading

Codecov Report

Merging #1296 (e2d9ce1) into main (3b1772b) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1296      +/-   ##
========================================
- Coverage   9.49%   9.47%   -0.03%     
========================================
  Files       1096    1096              
  Lines      76300   76469     +169     
  Branches   16996   17124     +128     
========================================
  Hits        7245    7245              
- Misses     62688   62843     +155     
- Partials    6367    6381      +14
Flag Coverage Δ *Carryforward flag
differential 4.95% <0.00%> (?)
total 9.47% <0.00%> (ø) Carriedforward from 3b1772b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ity_planner/src/scene_module/crosswalk/manager.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/crosswalk/scene_crosswalk.cpp 0.00% <0.00%> (ø)
...er/include/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1772b...e2d9ce1. Read the comment docs.

rej55
rej55 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 merged commit f8ba10b into autowarefoundation:main Jul 11, 2022
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 11, 2022
Merged
tier4-autoware-public-bot bot referenced this pull request in tier4/autoware.universe Jul 11, 2022
@tier4-autoware-public-bot
Merge pull request #83 from tier4/sync-upstream
f49d0fc 
fix(behavior_velocity_planner): fix rtc behavior in crosswalk module (#1296)
miursh pushed a commit to miursh/autoware.universe that referenced this pull request Jul 12, 2022
@taikitanaka3 @mitsudome-r
@fred-apex-ai @TakaHoribe @nnmm @jilaada @k0suke-murakami @kmiya @tkimura4 @wep21 @KeisukeShima @kenji-miyake @takayuki5168 @h-ohta @1222-takeshi
feat: add raw vehicle cmd converter package (autowarefoundation#79)
869e6bc 
* release v0.4.0

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit a2dc52036f5950188b5b4caedb2edcd36d3e5860.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* ROS2 Porting: raw_vehicle_cmd_converter (autowarefoundation#9)

* remove dependency to unused std_msgs package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rm COLCON_IGNORE

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* port raw_vehicle_cmd_converter to ROS2

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* port raw_vehicle_cmd_converter.launch to ROS2

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix typo

Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>

* fix typo

Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>

* remove include_directories form CMakeLists.txt

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix order of includes

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add missing comments

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>

* fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* ROS2 Linting: raw_vehicle_cmd_converter (autowarefoundation#161)

* Add linters

* Process linter corrections

* apply env_var to  use_sim_time (autowarefoundation#222)

* Ros2 v0.8.0 raw vehicle cmd converter (autowarefoundation#268)

* restore raw_vehicle_cmd_converter files for 0.8.0 update

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix typos in vehicle modules (autowarefoundation#954)

* add get func (autowarefoundation#1088)

* Revert "restore raw_vehicle_cmd_converter files for 0.8.0 update"

This reverts commit f243f26e20490757a332566aa92196553a682aa6.

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* update target branch for ci (autowarefoundation#309)

* update target branch for ci

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [as]: Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [latlon_muxer]: Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [map_based_prediction]: Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [raw_vehicle_cmd_converter]: Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [remote_cmd_converter]: Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [turn_signal_decider]: Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add plot_accel_brake_map.py (autowarefoundation#1249) (autowarefoundation#1296)

* add plot_accel_brake_map.py (autowarefoundation#1249)

* add plot_accel_brake_map.py

* call plotter from rosrun

* add permission

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* delete debug message

* Add license

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* apply format

* fix code

Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* Fix lint errors (autowarefoundation#1378)

* Fix lint errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix variable names

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* enable to designate directory of maps (autowarefoundation#1301) (autowarefoundation#1480)

* enable to designate directory of maps

* add error handling

* use argparser

Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Feature/vehicle interface improvements (autowarefoundation#1361) (autowarefoundation#1688)

* Feature/vehicle interface improvements (autowarefoundation#1361)

* add vehicle msg

* add pacmod interface

* add eps controller

* use each control commands instead of vehicle command

* fixed details

* fixed speell check

* const

* fixed brake status

* publish cmd when recieving ctrl cmd

* fix shift cmd ptr

* remove unused function and set proper license

* fix names

* fix typo for pacmod

* remove unnecessary waiting

* use flags, limit, multiarray

* remove accel brake dependency

* fix retrun value

* replace eps to steer

* cosmetic change for namespace

* fix segfo and retval

* Use Enum instead of int

* remove unused var

* add const

* rename to calcFFMap

* prev time steer calc

* add sample csv

* add new line

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Apply lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix build failure for remote cmd converter

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* replace to vehicle cmd emergency (autowarefoundation#1710) (autowarefoundation#1717)

* Fix subscriber topic type

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* Fix rclcpp::Time initialization

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* default debug value false in raw vehicle cmd converter (autowarefoundation#1755)

* default debug value false in raw vehicle cmd converter

* spell check

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [raw vehicle cmd converter] apply autoware auto msgs (autowarefoundation#519)

* remove ignore

* replace to autoware auto control message

* use localization odometry

* apply steering report

* appluy clang format

* cosmetic change

* fix spell check

* update to readme

* update launch

* minor fix

* precommit fix

* update README.md

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* using AckermannControlCommand

* fix format

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* move cmd converters to control pkg (autowarefoundation#642)

* auto/revert cmd converter (autowarefoundation#680)

* Revert "move cmd converters to control pkg (autowarefoundation#642)"

This reverts commit 19a10f9419aa25ef7a37e51c5df8f65b75cf8887.

* fix topic

* Auto/readme cmd converter (autowarefoundation#692)

* fix format

* add readme external cmd converter

* fix lint

* fiix sentence

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* fix format

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* fix sentence

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* better expression

Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

* fix door cmd topic (autowarefoundation#711)

* fix door cmd topic

* fix topic

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
@satoshi-ota satoshi-ota deleted the fix/crosswalk-rtc-behavior branch July 13, 2022 06:04
kosuke55 referenced this pull request in tier4/autoware.universe Jul 14, 2022
@satoshi-ota @kosuke55
fix(behavior_velocity_planner): fix rtc behavior in crosswalk module (#…
34125e5 
…1296)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@satoshi-ota @boyali
fix(behavior_velocity_planner): fix rtc behavior in crosswalk module (t…
437e5af 
…ier4#1296)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@satoshi-ota @boyali
fix(behavior_velocity_planner): fix rtc behavior in crosswalk module (t…
d2d6a75 
…ier4#1296)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@satoshi-ota @boyali
fix(behavior_velocity_planner): fix rtc behavior in crosswalk module (t…
bfbd0be 
…ier4#1296)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@satoshi-ota
fix(behavior_velocity_planner): fix rtc behavior in crosswalk module (a…
b2f7d53 
…utowarefoundation#1296)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@satoshi-ota @boyali
fix(behavior_velocity_planner): fix rtc behavior in crosswalk module (t…
3165f5e 
…ier4#1296)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rej55 rej55 rej55 approved these changes

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@tkhmy tkhmy Awaiting requested review from tkhmy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satoshi-ota @rej55