fix(tier4_integration_launch): add group tag #1236

angry-crab · 2022-07-05T06:03:51Z

Signed-off-by: Xinyu Wang xinyu.wang@tier4.jp

Description

Add group tag to launch files.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* release v0.4.0 * Add map diag (autowarefoundation#688) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change default value of disengage_on_route (autowarefoundation#703) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change localization diag namespace (autowarefoundation#718) * Change default value of output_diagnostics_topic Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove localization_diagnostic.js from web_controller Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Integrate localization diag to diagnostic_aggregator Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Delete old and unused publisher Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Support error in autoware state (autowarefoundation#728) * Support Error in autoware_state_monitor Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Refactor autoware_state_monitor Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Wait after planning completed Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Integrate FailedToArriveGoal and Error into Emergency state Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove override after arrived goal in autoware_state_monitor (autowarefoundation#737) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Improve autoware state monitor diag (autowarefoundation#792) * Add ok_list to stats Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use key-value Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add ok_list Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Revert "remove ROS1 packages temporarily" This reverts commit 470b35a4a07baca60033f7b363dba2f4279ff9c7. Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Rename launch files to launch.xml (autowarefoundation#28) * [WIP] ROS2 Porting: autoware_state_monitor (autowarefoundation#81) * Fix CMake and package.xml - Remove topic_tools deps in package.xml - Fix cmake refs - Build just core without other deps * Remove colcon ignore * Convert CMake to ament_cmake_auto * Fix package.xml with correct deps - Remove topic tools * Convert yaml files to be ROS2 compliant - Previous XmlRpc was used to collect yaml array like structures - Use _configs.names string array to locate config.<name>.<field> - Will need to convert the way the parametersa are retrieved * First pass - make compile * Port headers - Change the name of arrived goal for consistency - Port state machine - Port diagnostics wrapper methods * Add subscription, publisher and timers - Add simple parameters - Add back functionality - Add topic state functionality - Add functionality * Add configuration parameter implementations * Add launch files and clean up - Remove commented code from cmake and package.xml - Remove rosconsole.h * Clean up - Remove changes to autoware_sysytem_msgs - remove comments * Added types to the launch files - Make type arrays to allow for multiple types * Add rclcpp_generic implementation for subscriptions - Add the callback method back - Include exec_depends in package.xml * Clean up - Remove boost dependencies - Remove commented out dependencies - Remove comments * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * Add linters and fix some clang-tidy warnings (autowarefoundation#205) * [autoware_state_monitor] fix parameter in autoware_state_monitor.planning_simulation.yaml (autowarefoundation#244) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * Modify autoware state monitor (autowarefoundation#288) * comment out param config Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * fix minor issues Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * change engage from bool to control msg (autowarefoundation#292) Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * Ros2 v0.8.0 autoware state monitor (autowarefoundation#277) * Ros2 v0.8.0 engage (autowarefoundation#342) * [autoware_vehicle_msgs]: Add engage message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [as]: Update message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [awapi_awiv_adapter]: Update message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [web_controller]: Update message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [vehicle_cmd_gate]: Update message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [autoware_state_monitor]: Update message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [autoware_control_msgs]: Remove EngageMode message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * [simple_planning_simulator]: Update message Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix invalid exception handling (autowarefoundation#344) * remove invalid exception handling Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * remove unnecessary topics Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp> * Ros2 v0.8.0 fix packages (autowarefoundation#351) * add subscription to QoS * add vihicle_param _file to simple_planning_sim * update cmake/packages.xml * comment out unused parameter * apply lint * add vehicle_info_util to lane_change_planner * add vehicle_info_util to vehicle_cmd_gate * fix cmake of simple planning simulator * update cmake/packages.xml of vehicle cmd gate * apply lint * apply lint * add latch option to autoware_state_monitor * delete unused comment * fix implement miss in autoware_state_monitor * Rename ROS-related .yaml to .param.yaml (autowarefoundation#352) * Rename ROS-related .yaml to .param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove prefix 'default_' of yaml files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename vehicle_info.yaml to vehicle_info.param.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename diagnostic_aggregator's param files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix overlooked parameters Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ros2 v0.8.0 fix packages2 (autowarefoundation#354) * fix topic name * fix duration rate * fix sensing.yaml * fix topic name * add latch-option to autoware_state_monitor * fix timer callback * fix autoware state monitor config * fix sensing.yaml * Add parameter args to autoware_state_monitor.launch (autowarefoundation#1175) (autowarefoundation#385) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Feature/Add route cancel service (autowarefoundation#384) * Feature/Add route cancel service (autowarefoundation#1100) * Feature/Add route cancel service Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add guard Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix service name in launch Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * remove spin_some within service callback functions Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * apply ament_uncrustify Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * change wait time for state transition (autowarefoundation#416) * Sensor data qos (autowarefoundation#407) * Use sensor data qos for pointcloud preprocessor Signed-off-by: Autoware <autoware@tier4.jp> * Use sensor data qos for pointcloud Signed-off-by: Autoware <autoware@tier4.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Use sensor data qos for livox tag filter and vector map filter Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Autoware <autoware@tier4.jp> * Fix typo in system module (autowarefoundation#434) * Fix typo in system module * Change variable name * Move comments * Apply uncrustify * add use_sim-time option (autowarefoundation#454) * add missing topic to topic config list (autowarefoundation#1224) * remove pointcloud from state_monitor (autowarefoundation#1236) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Use integrated generic subscription (autowarefoundation#1342) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * suppress warnings for autoware_state_monitor (autowarefoundation#1722) * suppress warnings for autoware_state_monitor * fix style * re fix style * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix mistake Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> * Sync v1.3.0 (autowarefoundation#1909) * Add elevation_map to autoware_state_monitor (autowarefoundation#1907) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Disable saving elevation map temporarily (autowarefoundation#1906) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * sync rc (autowarefoundation#1930) * Remove elevation_map from autoware_state_monitor (autowarefoundation#1922) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Use base_ref (autowarefoundation#1925) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * Add autoware api (autowarefoundation#1979) * suport auto recovery on autoware_state_monitor (autowarefoundation#2006) * disable emergency check if hazard_status is not received (autowarefoundation#2024) * suppress warnings for system directory autowarefoundation#2046 * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Added warning about lookupTransform failure in autoware_status_monitor (autowarefoundation#2099) * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply Black Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Apply clang-format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build errors Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * [autoware state monitor] support autoware.auto msg (autowarefoundation#521) * support autoware.auto msg * add readme * remove unused code * remove emergency state * stop to subscribe hazard_status * remove VehicleStateReport/VehicleStateCommand/VehicleControlCommand (autowarefoundation#549) * fix autoware_error_monitor * fix state monitor * fix emergency handler(vehicle_state_report) * fix emergency Handler(vehicle_state_command) * fix shift_decider * fix emergency_handler(vehicle_control_command) * fix topic name * fix readme * Update system/autoware_state_monitor/Readme.md Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * fix format * Update system/autoware_state_monitor/launch/autoware_state_monitor.launch.xml Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * fix typo Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * [autowere_web_controller/autoware_state_monitor/emergency_handler]fix some packages (autowarefoundation#603) * fix vehicle_engage.js * fix autoware_state_monitor param * fix emergency_handler * oh * update autoware_state.js * [autoware_state_monitor]route -> had_map_route (autowarefoundation#635) * route -> had_map_route * Rename Readme.md to README.md Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> * Fix autoware monitors readme (autowarefoundation#629) * Fix readme of autoware_state_monitor * Fix readme of autoware_error_monitor * adapt to actuation cmd/status as control msg (autowarefoundation#646) * adapt to actuation cmd/status as control msg * fix readme * fix topics * fix remaing topics * as to pacmod interface * fix vehicle status * add header to twist * revert gyro_odometer_change * revert twist topic change * revert unchanged package * Fix topic name in autoware_state_monitor (autowarefoundation#667) * Fix no ground pointcloud topic name (autowarefoundation#733) Signed-off-by: j4tfwm6z <proj-jpntaxi@tier4.jp> Co-authored-by: j4tfwm6z <proj-jpntaxi@tier4.jp> * fix/rename segmentation namespace (autowarefoundation#742) * rename segmentation directory * fix namespace: system stack * fix namespace: planning * fix namespace: control stack * fix namespace: perception stack * fix readme Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Autoware <autoware@tier4.jp> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp> Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com> Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com> Co-authored-by: Yohei Mishina <66298900+YoheiMishina@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: j4tfwm6z <proj-jpntaxi@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>

codecov · 2022-07-13T05:57:13Z

Codecov Report

Merging #1236 (a5351ae) into main (27e2664) will increase coverage by 0.14%.
The diff coverage is n/a.

❗ Current head a5351ae differs from pull request most recent head 0ce8e9a. Consider uploading reports for the commit 0ce8e9a to get more accurate results

@@           Coverage Diff            @@
##            main   #1236      +/-   ##
========================================
+ Coverage   9.54%   9.69%   +0.14%     
========================================
  Files       1096    1051      -45     
  Lines      76557   69123    -7434     
  Branches   17207   15535    -1672     
========================================
- Hits        7310    6702     -608     
+ Misses     62435   56567    -5868     
+ Partials    6812    5854     -958

Flag	Coverage Δ		*Carryforward flag
differential	`∅ <ø> (?)`
total	`9.69% <ø> (+0.16%)`	⬆️	Carriedforward from c45e597

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...ator/nodes/costmap_generator/points_to_costmap.cpp	`0.00% <0.00%> (-82.36%)`	⬇️
...auto_common/include/helper_functions/type_name.hpp	`66.66% <0.00%> (-33.34%)`	⬇️
..._utils/include/grid_map_utils/polygon_iterator.hpp	`50.00% <0.00%> (-25.00%)`	⬇️
...or/include/planning_error_monitor/debug_marker.hpp	`50.00% <0.00%> (-25.00%)`	⬇️
map/lanelet2_extension/lib/route_checker.cpp	`77.77% <0.00%> (-11.12%)`	⬇️
...oware_auto_geometry/test/src/test_hull_pockets.cpp	`45.65% <0.00%> (-10.60%)`	⬇️
...autoware_auto_geometry/test/src/test_common_2d.cpp	`42.85% <0.00%> (-10.48%)`	⬇️
...ion/include/fault_injection/diagnostic_storage.hpp	`53.84% <0.00%> (-7.70%)`	⬇️
common/motion_testing/test/trajectory_checks.cpp	`20.00% <0.00%> (-7.28%)`	⬇️
...oware_auto_geometry/test/src/test_intersection.cpp	`40.54% <0.00%> (-6.96%)`	⬇️
... and 624 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 910d6c8...0ce8e9a. Read the comment docs.

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

…imer-cherrypicks fix(multi_object_tracker): mot timer cherrypicks

fix(tier4_integration_launch): add group tag

a5351ae

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

angry-crab requested a review from h-ohta July 5, 2022 06:03

angry-crab mentioned this pull request Jul 5, 2022

<arg> is overwritten when including multiple launch files because <include> does not scope #1160

Closed

13 tasks

h-ohta approved these changes Jul 8, 2022

View reviewed changes

angry-crab enabled auto-merge (squash) July 12, 2022 04:52

Merge branch 'main' into fix_integration_launch

0ce8e9a

angry-crab merged commit 5bcfb9c into autowarefoundation:main Jul 13, 2022

angry-crab deleted the fix_integration_launch branch July 13, 2022 08:42

tier4-autoware-public-bot bot mentioned this pull request Jul 14, 2022

chore: sync upstream tier4/autoware.universe#88

Merged

kosuke55 referenced this pull request in tier4/autoware.universe Jul 14, 2022

fix(tier4_integration_launch): add group tag (#1236)

03bc1ef

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022

fix(tier4_integration_launch): add group tag (tier4#1236)

6861b04

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022

fix(tier4_integration_launch): add group tag (tier4#1236)

fab64b2

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022

fix(tier4_integration_launch): add group tag (tier4#1236)

d341264

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022

fix(tier4_integration_launch): add group tag (autowarefoundation#1236)

7f48dfb

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022

fix(tier4_integration_launch): add group tag (tier4#1236)

8f7c653

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jun 12, 2024

Merge pull request autowarefoundation#1236 from technolojin/tmp/mot-t…

4f814c2

…imer-cherrypicks fix(multi_object_tracker): mot timer cherrypicks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tier4_integration_launch): add group tag #1236

fix(tier4_integration_launch): add group tag #1236

angry-crab commented Jul 5, 2022 •

edited

Loading

codecov bot commented Jul 13, 2022

fix(tier4_integration_launch): add group tag #1236

fix(tier4_integration_launch): add group tag #1236

Conversation

angry-crab commented Jul 5, 2022 • edited Loading

Description

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Jul 13, 2022

Codecov Report

angry-crab commented Jul 5, 2022 •

edited

Loading