Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_autoware_utils): add point interpolation function #1100

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jun 14, 2022

Description

Add point interpolation function to tier4_autoware_utils.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1100 (19cc4b1) into main (373c91a) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

@@           Coverage Diff            @@
##            main   #1100      +/-   ##
========================================
- Coverage   9.02%   9.00%   -0.03%     
========================================
  Files       1025    1025              
  Lines      69477   69834     +357     
  Branches   11725   11790      +65     
========================================
+ Hits        6271    6289      +18     
- Misses     58001   58324     +323     
- Partials    5205    5221      +16     
Flag Coverage Δ *Carryforward flag
differential 9.28% <40.00%> (?)
total 8.96% <ø> (-0.05%) ⬇️ Carriedforward from 1d0bdc7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/tier4_autoware_utils/geometry/geometry.hpp 92.00% <ø> (ø)
...autoware_utils/test/src/geometry/test_geometry.cpp 37.19% <40.00%> (+0.07%) ⬆️
planning/behavior_path_planner/src/utilities.cpp 0.00% <0.00%> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.00% <0.00%> (ø)
...or_path_planner/src/scene_module/pull_out/util.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
...nodes/costmap_generator/costmap_generator_node.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
.../scenario_selector_node/scenario_selector_node.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 373c91a...19cc4b1. Read the comment docs.

@takayuki5168
Copy link
Contributor

@purewater0901 Where do you think we will use this function in the application. Usually, we use Pose which includes orientation.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 enabled auto-merge (squash) June 15, 2022 02:39
Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 merged commit 34c4f51 into autowarefoundation:main Jun 15, 2022
@purewater0901 purewater0901 deleted the feat/add-point-interpolation branch June 15, 2022 05:14
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
yukkysaito pushed a commit to yukkysaito/autoware.universe that referenced this pull request Jun 29, 2022
* release v0.4.0

* Add map diag (autowarefoundation#688)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change default value of disengage_on_route (autowarefoundation#703)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change localization diag namespace (autowarefoundation#718)

* Change default value of output_diagnostics_topic

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove localization_diagnostic.js from web_controller

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Integrate localization diag to diagnostic_aggregator

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Delete old and unused publisher

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Support error in autoware state (autowarefoundation#728)

* Support Error in autoware_state_monitor

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Refactor autoware_state_monitor

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Wait after planning completed

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Integrate FailedToArriveGoal and Error into Emergency state

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove override after arrived goal in autoware_state_monitor (autowarefoundation#737)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Improve autoware state monitor diag (autowarefoundation#792)

* Add ok_list to stats

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use key-value

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add ok_list

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit 470b35a4a07baca60033f7b363dba2f4279ff9c7.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Rename launch files to launch.xml (autowarefoundation#28)

* [WIP] ROS2 Porting: autoware_state_monitor (autowarefoundation#81)

* Fix CMake and package.xml
 - Remove topic_tools deps in package.xml
 - Fix cmake refs
 - Build just core without other deps

* Remove colcon ignore

* Convert CMake to ament_cmake_auto

* Fix package.xml with correct deps
 - Remove topic tools

* Convert yaml files to be ROS2 compliant
 - Previous XmlRpc was used to collect yaml array like structures
 - Use _configs.names string array to locate config.<name>.<field>
 - Will need to convert the way the parametersa are retrieved

* First pass - make compile

* Port headers
 - Change the name of arrived goal for consistency
 - Port state machine
 - Port diagnostics wrapper methods

* Add subscription, publisher and timers
 - Add simple parameters
 - Add back functionality
 - Add topic state functionality
 - Add functionality

* Add configuration parameter implementations

* Add launch files and clean up
 - Remove commented code from cmake and package.xml
 - Remove rosconsole.h

* Clean up
 - Remove changes to autoware_sysytem_msgs
 - remove comments

* Added types to the launch files
 - Make type arrays to allow for multiple types

* Add rclcpp_generic implementation for subscriptions
 - Add the callback method back
 - Include exec_depends in package.xml

* Clean up
 - Remove boost dependencies
 - Remove commented out dependencies
 - Remove comments

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* Add linters and fix some clang-tidy warnings (autowarefoundation#205)

* [autoware_state_monitor] fix parameter in autoware_state_monitor.planning_simulation.yaml (autowarefoundation#244)

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Modify autoware state monitor (autowarefoundation#288)

* comment out param config

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* fix minor issues

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* change engage from bool to control msg (autowarefoundation#292)

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Ros2 v0.8.0 autoware state monitor (autowarefoundation#277)

* Ros2 v0.8.0 engage (autowarefoundation#342)

* [autoware_vehicle_msgs]: Add engage message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [as]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [awapi_awiv_adapter]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [web_controller]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [vehicle_cmd_gate]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autoware_state_monitor]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autoware_control_msgs]: Remove EngageMode message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [simple_planning_simulator]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix invalid exception handling (autowarefoundation#344)

* remove invalid exception handling

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* remove unnecessary topics

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* Ros2 v0.8.0 fix packages (autowarefoundation#351)

* add subscription to QoS

* add vihicle_param _file to simple_planning_sim

* update cmake/packages.xml

* comment out unused parameter

* apply lint

* add vehicle_info_util to lane_change_planner

* add vehicle_info_util to vehicle_cmd_gate

* fix cmake of simple planning simulator

* update cmake/packages.xml of vehicle cmd gate

* apply lint

* apply lint

* add latch option to autoware_state_monitor

* delete unused comment

* fix implement miss in autoware_state_monitor

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#352)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove prefix 'default_' of yaml files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename diagnostic_aggregator's param files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix overlooked parameters

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ros2 v0.8.0 fix packages2 (autowarefoundation#354)

* fix topic name

* fix duration rate

* fix sensing.yaml

* fix topic name

* add latch-option to autoware_state_monitor

* fix timer callback

* fix autoware state monitor config

* fix sensing.yaml

* Add parameter args to autoware_state_monitor.launch (autowarefoundation#1175) (autowarefoundation#385)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Feature/Add route cancel service (autowarefoundation#384)

* Feature/Add route cancel service (autowarefoundation#1100)

* Feature/Add route cancel service

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add guard

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix service name in launch

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* remove spin_some within service callback functions

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* apply ament_uncrustify

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* change wait time for state transition (autowarefoundation#416)

* Sensor data qos (autowarefoundation#407)

* Use sensor data qos for pointcloud preprocessor

Signed-off-by: Autoware <autoware@tier4.jp>

* Use sensor data qos for pointcloud

Signed-off-by: Autoware <autoware@tier4.jp>

* Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Use sensor data qos for livox tag filter and vector map filter

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Autoware <autoware@tier4.jp>

* Fix typo in system module (autowarefoundation#434)

* Fix typo in system module

* Change variable name

* Move comments

* Apply uncrustify

* add use_sim-time option (autowarefoundation#454)

* add missing topic to topic config list (autowarefoundation#1224)

* remove pointcloud from state_monitor (autowarefoundation#1236)

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Use integrated generic subscription (autowarefoundation#1342)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* suppress warnings for autoware_state_monitor (autowarefoundation#1722)

* suppress warnings for autoware_state_monitor

* fix style

* re fix style

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* Sync v1.3.0 (autowarefoundation#1909)

* Add elevation_map to autoware_state_monitor (autowarefoundation#1907)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Disable saving elevation map temporarily (autowarefoundation#1906)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* sync rc (autowarefoundation#1930)

* Remove elevation_map from autoware_state_monitor (autowarefoundation#1922)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Use base_ref (autowarefoundation#1925)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* Add autoware api (autowarefoundation#1979)

* suport auto recovery on autoware_state_monitor (autowarefoundation#2006)

* disable emergency check if hazard_status is not received (autowarefoundation#2024)

* suppress warnings for system directory autowarefoundation#2046

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Added warning about lookupTransform failure in autoware_status_monitor (autowarefoundation#2099)

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [autoware state monitor] support autoware.auto msg (autowarefoundation#521)

* support autoware.auto msg

* add readme

* remove unused code

* remove emergency state

* stop to subscribe hazard_status

* remove VehicleStateReport/VehicleStateCommand/VehicleControlCommand (autowarefoundation#549)

* fix autoware_error_monitor

* fix state monitor

* fix emergency handler(vehicle_state_report)

* fix emergency Handler(vehicle_state_command)

* fix shift_decider

* fix emergency_handler(vehicle_control_command)

* fix topic name

* fix readme

* Update system/autoware_state_monitor/Readme.md

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* fix format

* Update system/autoware_state_monitor/launch/autoware_state_monitor.launch.xml

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* fix typo

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* [autowere_web_controller/autoware_state_monitor/emergency_handler]fix some packages (autowarefoundation#603)

* fix vehicle_engage.js

* fix autoware_state_monitor param

* fix emergency_handler

* oh

* update autoware_state.js

* [autoware_state_monitor]route -> had_map_route (autowarefoundation#635)

* route -> had_map_route

* Rename Readme.md to README.md

Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>

* Fix autoware monitors readme (autowarefoundation#629)

* Fix readme of autoware_state_monitor

* Fix readme of autoware_error_monitor

* adapt to actuation cmd/status as control msg (autowarefoundation#646)

* adapt to actuation cmd/status as control msg

* fix readme

* fix topics

* fix remaing topics

* as to pacmod interface

* fix vehicle status

* add header to twist

* revert gyro_odometer_change

* revert twist topic change

* revert unchanged package

* Fix topic name in autoware_state_monitor (autowarefoundation#667)

* Fix no ground pointcloud topic name (autowarefoundation#733)

Signed-off-by: j4tfwm6z <proj-jpntaxi@tier4.jp>

Co-authored-by: j4tfwm6z <proj-jpntaxi@tier4.jp>

* fix/rename segmentation namespace (autowarefoundation#742)

* rename segmentation directory

* fix namespace: system stack

* fix namespace: planning

* fix namespace: control stack

* fix namespace: perception stack

* fix readme

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Jilada Eccleston <jilada.eccleston@gmail.com>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Yohei Mishina <66298900+YoheiMishina@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: j4tfwm6z <proj-jpntaxi@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
yn-mrse referenced this pull request in tier4/autoware.universe Jun 21, 2023
#1100, #1126) (#592)

* feat(tier4_autoware_utils): add pose interpolation function (#1097)

Signed-off-by: yutaka <purewater0901@gmail.com>

* feat(tier4_autoware_utils): add new orientation calculation (#1126)

* feat(tier4_autoware_utils): add new orientation calculation

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix format

* feat(tier4_autoware_utils): add point interpolation function (#1100)

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
Co-authored-by: Yutaka Shimizu <43805014+purewater0901@users.noreply.github.com>
tzhong518 pushed a commit to tzhong518/autoware.universe that referenced this pull request Jan 23, 2024
fix(bpp): cherry pick behavior path module improvement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants