`<arg>` is overwritten when including multiple launch files because `<include>` does not scope

[h-ohta]

Checklist

• I've read the contribution guidelines.
• I've searched other issues and no duplicate issues were found.
• I've agreed with the maintainers that I can plan this task.

Description

We probably have same issue as ros2/launch#620.

Purpose

We have to fix above issue to avoid unexpected error in the future.

Possible approaches

add <group> tag around <include> tag is better.

Definition of done

Now, I only confirm and fix in tier4_xxx_launch directory.

• tier4_autoware_api_launch
• tier4_control_launch
• tier4_integration_launch
• tier4_localization_launch
• tier4_perception_launch
• tier4_planning_launch
• tier4_sensing_launch
• tier4_simulator_launch
• tier4_system_launch
• tier4_vehicle_launch

[angry-crab]

If there is only one include in a launch file, is group tag still necessary?

[angry-crab]

Recreated PRs
#1235
#1236
#1237
#1238
#1239
#1240

[h-ohta]

If there is only one include in a launch file, is group tag still necessary?

Sorry for late reply. It would be better.

[angry-crab]

All related PRs are merged. I think we can close this issue. The unchecked packages are good.

[h-ohta]

I've confirmed. LGTM

[h-ohta]

@angry-crab Thank you for your cooperation!