Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prevent-no-label-execution workflow #19

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

kenji-miyake
Copy link
Contributor

Kenji Miyake added 3 commits December 14, 2021 22:33
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake
Copy link
Contributor Author

@KeisukeShima Although I'll merge this now for autoware.universe, please leave your reviews and questions on this PR if there are any comments. 🙏

@kenji-miyake kenji-miyake changed the title feat: add prevent no label execution feat: add prevent-no-label-execution action Dec 14, 2021
@kenji-miyake kenji-miyake merged commit ae3e241 into tier4/proposal Dec 14, 2021
@kenji-miyake kenji-miyake deleted the add-prevent-no-label-execution branch December 14, 2021 13:54
@kenji-miyake kenji-miyake changed the title feat: add prevent-no-label-execution action feat: add prevent-no-label-execution workflow Dec 14, 2021
kenji-miyake added a commit that referenced this pull request Dec 14, 2021
* feat: add prevent-no-label-execution action

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* use reusable workflow

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix bug

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Copy link
Contributor

@KeisukeShima KeisukeShima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment. Other parts are LGTM.

Comment on lines +53 to +54
needs: check-run-condition
if: ${{ needs.check-run-condition.outputs.run == 'true' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
needs: check-run-condition
if: ${{ needs.check-run-condition.outputs.run == 'true' }}
needs: prevent-no-label-execution
if: ${{ needs.prevent-no-label-execution.outputs.run == 'true' }}

This is a minor suggestion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it was old. Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants