-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prevent-no-label-execution workflow #19
Conversation
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
a4ecad5
to
b8519c0
Compare
@KeisukeShima Although I'll merge this now for |
* feat: add prevent-no-label-execution action Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * use reusable workflow Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * fix bug Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment. Other parts are LGTM.
needs: check-run-condition | ||
if: ${{ needs.check-run-condition.outputs.run == 'true' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs: check-run-condition | |
if: ${{ needs.check-run-condition.outputs.run == 'true' }} | |
needs: prevent-no-label-execution | |
if: ${{ needs.prevent-no-label-execution.outputs.run == 'true' }} |
This is a minor suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it was old. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For autowarefoundation/autoware.universe#173