This repository was archived by the owner on Nov 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Switch from setup.py to pyproject.toml (AR-1624) #1459
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1459 +/- ##
=======================================
Coverage 89.84% 89.84%
=======================================
Files 17 17
Lines 827 827
=======================================
Hits 743 743
Misses 84 84
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Pasarus
suggested changes
Jul 13, 2022
Member
Pasarus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the last PR! Just fix it up and it's ready for a merge!
Co-authored-by: Samuel Jones <samjones714@gmail.com>
Co-authored-by: Samuel Jones <samjones714@gmail.com>
Co-authored-by: Samuel Jones <samjones714@gmail.com>
Pasarus
approved these changes
Jul 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
python setup.py sdist bdist_wheeltopython -m buildfor packaging projectHow to test your work
Try running
pip install utilsandpip install -e utils(Editable) from the root repo (workspace). Ensure this installs without any errors