Skip to content
This repository was archived by the owner on Nov 14, 2022. It is now read-only.

Conversation

@james0209
Copy link
Contributor

@james0209 james0209 commented Jul 8, 2022

Changes

  • Transitions away from deprecated setup.py to the new standard pyproject.toml
  • Switch from using python setup.py sdist bdist_wheel to python -m build for packaging project
  • Combines .pylintrc .yapfignore and pytest.ini config files into the pyproject.toml file
  • Remove references to Python 3.6 (3.8 is the current version being used)
  • Fix pylint issues that arose from using new version (removing usage of no-self-use - now an optional extension)

How to test your work

Try running pip install utils and pip install -e utils (Editable) from the root repo (workspace). Ensure this installs without any errors

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #1459 (d4fda8e) into main (b1b24fb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1459   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files          17       17           
  Lines         827      827           
=======================================
  Hits          743      743           
  Misses         84       84           
Flag Coverage Δ
backend 89.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@james0209 james0209 changed the title Switch to pyproject.toml Switch from setup.py to pyproject.toml (AR-1624) Jul 11, 2022
@james0209 james0209 marked this pull request as ready for review July 11, 2022 12:51
Copy link
Member

@Pasarus Pasarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the last PR! Just fix it up and it's ready for a merge!

james0209 and others added 3 commits July 13, 2022 09:43
Co-authored-by: Samuel Jones <samjones714@gmail.com>
Co-authored-by: Samuel Jones <samjones714@gmail.com>
Co-authored-by: Samuel Jones <samjones714@gmail.com>
@Pasarus Pasarus merged commit 2742b85 into main Jul 13, 2022
@Pasarus Pasarus deleted the 1624-switch-pyproject-toml-AR-1624 branch July 13, 2022 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants