Skip to content
This repository was archived by the owner on Nov 14, 2022. It is now read-only.

Commit 4cbb438

Browse files
author
Dimitar Tasev
authored
Merge pull request #1320 from ISISScientificComputing/allow_null_variable_value
2 parents ffa5549 + 455442d commit 4cbb438

File tree

4 files changed

+38
-6
lines changed

4 files changed

+38
-6
lines changed

WebApp/autoreduce_webapp/autoreduce_webapp/fixtures/run_with_multiple_variables.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@
119119
"pk": 6,
120120
"fields": {
121121
"name": "variable_none",
122-
"value": "None",
122+
"value": null,
123123
"type": "text",
124124
"is_advanced": false,
125125
"help_text": ""
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# Generated by Django 3.1.2 on 2021-04-26 14:19
2+
3+
from django.db import migrations, models
4+
5+
6+
class Migration(migrations.Migration):
7+
8+
dependencies = [
9+
('instrument', '0001_initial'),
10+
]
11+
12+
operations = [
13+
migrations.AlterField(
14+
model_name='variable',
15+
name='value',
16+
field=models.CharField(blank=True, max_length=300, null=True),
17+
),
18+
]
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# Generated by Django 3.1.2 on 2021-04-26 14:28
2+
3+
from django.db import migrations
4+
5+
6+
class Migration(migrations.Migration):
7+
8+
dependencies = [
9+
('instrument', '0002_auto_20210426_1519'),
10+
('instrument', '0002_alter_variable_value'),
11+
]
12+
13+
operations = [
14+
]

WebApp/autoreduce_webapp/instrument/models.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,11 @@ class Variable(models.Model):
1616
Generic model class that should be treated as abstract
1717
"""
1818
name = models.CharField(max_length=50, blank=False)
19-
value = models.CharField(max_length=300, blank=True)
19+
value = models.CharField(max_length=300, blank=True, null=True)
2020
type = models.CharField(max_length=50, blank=False)
2121
is_advanced = models.BooleanField(default=False)
2222
help_text = models.TextField(blank=True, null=True, default='')
2323

24-
# pylint:disable=no-member
25-
def __str__(self):
26-
return f"{self.instrument.name} - {self.name}=self.value"
27-
2824
def sanitized_name(self):
2925
"""
3026
Returns a HTMl-friendly name that can be used as element IDs or form input names
@@ -48,6 +44,10 @@ class InstrumentVariable(Variable):
4844
start_run = models.IntegerField(blank=True, null=True)
4945
tracks_script = models.BooleanField(default=False)
5046

47+
# pylint:disable=no-member
48+
def __str__(self):
49+
return f"{self.instrument.name} - {self.name}=self.value"
50+
5151

5252
class RunVariable(models.Model):
5353
"""

0 commit comments

Comments
 (0)