Switch to tox (AR-1667) (#1481)

* Try testing tox

* Try again

* Skip packaging operation

* And again

* Add pytest-django

* Add in parameterized as a dependency

* Move pytest options to pyproject.toml

* Specify explicit path {envsitepackagesdir}/mypkg to pytest.

To fix pytest importing from checkout and not installed

* Move extras to the correct config

* Update tox.ini

* Fix rogue reference to wrong test folder

* Add code inspection tests

* Create all-in-one code inspection

* Remove repeated data

* Remove unused command

* Update cov folder

* Remove extras sections as I believe it
is inherited from base [testenv]

* Keep build actions as is

* Fix typo and pin setuptools

Author: james0209

.github/workflows/run-tests.yml

@@ -34,13 +34,11 @@ jobs:
         with:
           repository: "autoreduction/autoreduce-workspace"
 
-      - name: Run system tests
-        run: |
-          RUNNING_VIA_PYTEST=true pytest autoreduce_qp/systemtests --cov-append -v
+      - name: Install Tox
+        run: python -m pip install tox tox-gh-actions
 
-      - name: Run unit tests
-        run: >-
-          RUNNING_VIA_PYTEST=true pytest --ignore=autoreduce_qp/systemtests --cov=autoreduce_qp --cov-report=xml -v autoreduce_qp
+      - name: Test with tox
+        run: tox -e pytest
 
       - uses: codecov/codecov-action@v3
         with:
@@ -86,8 +84,7 @@ jobs:
       - name: Pip install
         run: |
           pip install --upgrade pip
-          [ -f "requirements.txt" ] && pip install -r requirements.txt || echo "No requirements.txt found"
-          pip install -e .
+          pip install -e .[dev]
 
   Inspection:
     name: Code Inspection
@@ -116,6 +113,8 @@ jobs:
         with:
           package_name: autoreduce_qp
 
-      - uses: autoreduction/autoreduce-actions/code_inspection@main
-        with:
-          package_name: autoreduce_qp
+      - name: Install Tox
+        run: python -m pip install tox tox-gh-actions
+
+      - name: Run code inspection with tox
+        run: tox -e code_inspection

.gitignore

@@ -1,59 +1,256 @@
-# Ignore IDE files
-.idea/*
-*/target/**
-.pytest_cache/
-
+# Created by https://www.toptal.com/developers/gitignore/api/python,django
+# Edit at https://www.toptal.com/developers/gitignore?templates=python,django
 
-# Ignore complied python
+### Django ###
+*.log
+*.pot
 *.pyc
+__pycache__/
+local_settings.py
+db.sqlite3
+db.sqlite3-journal
+media
 
-# Ignore log data
-*.log
-logs/
+# If your build process includes running collectstatic, then you probably don't need or want to include staticfiles/
+# in your Git repository. Update and uncomment the following line accordingly.
+# <django-project-name>/staticfiles/
 
-# *.out
+### Django.Python Stack ###
+# Byte-compiled / optimized / DLL files
+*.py[cod]
+*$py.class
 
-# Ignore credentials files
-credentials.ini
+# C extensions
+*.so
 
-# Ignore distutils installation
+# Distribution / packaging
+.Python
+build/
+develop-eggs/
 dist/
+downloads/
+eggs/
+.eggs/
+lib/
+lib64/
+parts/
+sdist/
+var/
+wheels/
+share/python-wheels/
+*.egg-info/
+.installed.cfg
+*.egg
+MANIFEST
+
+# PyInstaller
+#  Usually these files are written by a python script from a template
+#  before PyInstaller builds the exe, so as to inject date/other infos into it.
+*.manifest
+*.spec
+
+# Installer logs
+pip-log.txt
+pip-delete-this-directory.txt
+
+# Unit test / coverage reports
+htmlcov/
+.tox/
+.nox/
+.coverage
+.coverage.*
+.cache
+nosetests.xml
+coverage.xml
+*.cover
+*.py,cover
+.hypothesis/
+.pytest_cache/
+cover/
+
+# Translations
+*.mo
+
+# Django stuff:
+
+# Flask stuff:
+instance/
+.webassets-cache
+
+# Scrapy stuff:
+.scrapy
+
+# Sphinx documentation
+docs/_build/
 
-# Ignore virtual environment
+# PyBuilder
+.pybuilder/
+target/
+
+# Jupyter Notebook
+.ipynb_checkpoints
+
+# IPython
+profile_default/
+ipython_config.py
+
+# pyenv
+#   For a library or package, you might want to ignore these files since the code is
+#   intended to run in multiple environments; otherwise, check them in:
+# .python-version
+
+# pipenv
+#   According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control.
+#   However, in case of collaboration, if having platform-specific dependencies or dependencies
+#   having no cross-platform support, pipenv may install dependencies that don't work, or not
+#   install all needed dependencies.
+#Pipfile.lock
+
+# poetry
+#   Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control.
+#   This is especially recommended for binary packages to ensure reproducibility, and is more
+#   commonly ignored for libraries.
+#   https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control
+#poetry.lock
+
+# pdm
+#   Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control.
+#pdm.lock
+#   pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it
+#   in version control.
+#   https://pdm.fming.dev/#use-with-ide
+.pdm.toml
+
+# PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm
+__pypackages__/
+
+# Celery stuff
+celerybeat-schedule
+celerybeat.pid
+
+# SageMath parsed files
+*.sage.py
+
+# Environments
+.env
+.venv
+env/
 venv/
-venv3/
-venv36/
-venv37/
+ENV/
+env.bak/
+venv.bak/
 
-# Ignore pip install installation
-autoreduce_qp.egg-info/
+# Spyder project settings
+.spyderproject
+.spyproject
 
-# This is generated from a template so should be ignored to force regeneration
-apache_django_wsgi.conf
+# Rope project settings
+.ropeproject
 
-# Ignore coverage logs
-.coverage
+# mkdocs documentation
+/site
 
-# Include the coverage configuration file
-!.coveragerc
+# mypy
+.mypy_cache/
+.dmypy.json
+dmypy.json
 
-# Ignore site.retry from Ansible
-site.retry
-vault.yml
+# Pyre type checker
+.pyre/
 
-.DS_Store
+# pytype static type analyzer
+.pytype/
 
-# Ignore developer specific .vscode/settings.json
-.vscode/settings.json
+# Cython debug symbols
+cython_debug/
 
-# ignore sqlite3 db files
-**/sqlite3*.db*
+# PyCharm
+#  JetBrains specific template is maintained in a separate JetBrains.gitignore that can
+#  be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore
+#  and can be added to the global gitignore or merged into this file.  For a more nuclear
+#  option (not recommended) you can uncomment the following to ignore the entire idea folder.
+#.idea/
 
-# folders that get created from tests
-reduced-data/
-data-archive/
-test-archive/
+### Python ###
+# Byte-compiled / optimized / DLL files
 
-# pip build files
-build/
-dist/
+# C extensions
+
+# Distribution / packaging
+
+# PyInstaller
+#  Usually these files are written by a python script from a template
+#  before PyInstaller builds the exe, so as to inject date/other infos into it.
+
+# Installer logs
+
+# Unit test / coverage reports
+
+# Translations
+
+# Django stuff:
+
+# Flask stuff:
+
+# Scrapy stuff:
+
+# Sphinx documentation
+
+# PyBuilder
+
+# Jupyter Notebook
+
+# IPython
+
+# pyenv
+#   For a library or package, you might want to ignore these files since the code is
+#   intended to run in multiple environments; otherwise, check them in:
+# .python-version
+
+# pipenv
+#   According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control.
+#   However, in case of collaboration, if having platform-specific dependencies or dependencies
+#   having no cross-platform support, pipenv may install dependencies that don't work, or not
+#   install all needed dependencies.
+
+# poetry
+#   Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control.
+#   This is especially recommended for binary packages to ensure reproducibility, and is more
+#   commonly ignored for libraries.
+#   https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control
+
+# pdm
+#   Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control.
+#   pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it
+#   in version control.
+#   https://pdm.fming.dev/#use-with-ide
+
+# PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm
+
+# Celery stuff
+
+# SageMath parsed files
+
+# Environments
+
+# Spyder project settings
+
+# Rope project settings
+
+# mkdocs documentation
+
+# mypy
+
+# Pyre type checker
+
+# pytype static type analyzer
+
+# Cython debug symbols
+
+# PyCharm
+#  JetBrains specific template is maintained in a separate JetBrains.gitignore that can
+#  be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore
+#  and can be added to the global gitignore or merged into this file.  For a more nuclear
+#  option (not recommended) you can uncomment the following to ignore the entire idea folder.
+
+# End of https://www.toptal.com/developers/gitignore/api/python,django

autoreduce_qp/pytest.ini

@@ -21,7 +21,7 @@ dependencies = [
 ]
 
 [project.optional-dependencies]
-dev = []
+dev = ["parameterized==0.8.1", "pytest==7.1.2"]
 
 [project.urls]
 "Repository" = "https://github.com/autoreduction/queue-processor"
@@ -34,6 +34,11 @@ autoreduce-runner-start = "autoreduce_qp.queue_processor.reduction.runner:main"
 [tool.setuptools]
 packages = ["autoreduce_qp"]
 
+[tool.pytest.ini_options]
+DJANGO_SETTINGS_MODULE = "autoreduce_django.settings"
+norecursedirs = [".*", "dist", "CVS", "_darcs", "{arch}", "*.egg"]
+python_files = ["tests.py", "test_*.py", "*_tests.py"]
+
 [tool.yapf]
 column_limit = 120
 based_on_style = "pep8"