-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Enabled pipeline fit #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled pipeline fit #1096
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1096 +/- ##
===============================================
+ Coverage 85.46% 85.48% +0.01%
===============================================
Files 137 137
Lines 10557 10618 +61
===============================================
+ Hits 9023 9077 +54
- Misses 1534 1541 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, just a bunch of comments on the API. I think we can discuss all of this offline later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa, this feature is way more complicated than I anticipated. Also, do you think #709 can be solved as a side effect?
Looks good, I only have four (hopefully small) comment left. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I just tried this locally to debug a weird pipeline and have a few more suggestions. But this features will be really helpful (and already was, uncovered a pretty nasty bug using it)!
addresses #886