Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Be able to display error messages in additional info as it is #225

Merged
merged 3 commits into from
Jun 30, 2021

Conversation

nabenabe0928
Copy link
Collaborator

@nabenabe0928 nabenabe0928 commented May 21, 2021

Since the latest version print additional info as dict, it does not show the error as it is supposed to be looked like.

@nabenabe0928 nabenabe0928 requested review from franchuterivera and ravinkohli and removed request for franchuterivera May 21, 2021 08:09
Copy link
Contributor

@ravinkohli ravinkohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Thanks for this PR. I have requested some minor changes.

@nabenabe0928 nabenabe0928 force-pushed the hotfix-logger-message branch from d3506d4 to d13e402 Compare June 24, 2021 21:36
@nabenabe0928 nabenabe0928 requested a review from ravinkohli June 24, 2021 21:49
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #225 (7d2a396) into development (8237f2c) will decrease coverage by 0.05%.
The diff coverage is 83.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #225      +/-   ##
===============================================
- Coverage        81.76%   81.70%   -0.06%     
===============================================
  Files              151      151              
  Lines             8641     8647       +6     
  Branches          1326     1328       +2     
===============================================
  Hits              7065     7065              
- Misses            1104     1108       +4     
- Partials           472      474       +2     
Impacted Files Coverage Δ
autoPyTorch/api/base_task.py 84.50% <62.50%> (-0.15%) ⬇️
autoPyTorch/evaluation/abstract_evaluator.py 75.89% <100.00%> (ø)
autoPyTorch/evaluation/tae.py 67.57% <100.00%> (ø)
autoPyTorch/evaluation/train_evaluator.py 87.20% <100.00%> (ø)
autoPyTorch/optimizer/smbo.py 79.83% <100.00%> (ø)
autoPyTorch/utils/common.py 87.87% <100.00%> (+0.78%) ⬆️
...ipeline/components/setup/network_backbone/utils.py 87.21% <0.00%> (-1.51%) ⬇️
autoPyTorch/ensemble/ensemble_builder.py 73.58% <0.00%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8237f2c...7d2a396. Read the comment docs.

@ravinkohli ravinkohli merged commit 9002937 into automl:development Jun 30, 2021
github-actions bot pushed a commit that referenced this pull request Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants