Skip to content

Commit 9cd8535

Browse files
committed
Fix a few words and add objective.latency_threshold to table of labels for duration histograms
1 parent 559ac8d commit 9cd8535

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

specs/autometrics_v1.0.0.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ Libraries MAY need an initialization function.
4747
Libraries SHOULD expose functionality to make the metrics available to the
4848
user in either the Prometheus text format or the OpenTelemetry Protocol (otlp).
4949
It is up to the user to decide whether they want to implement a push or pull
50-
based model. Libraries MAY provide higher level implementation to expose the
50+
based model. Libraries MAY provide higher level implementations to expose the
5151
metrics in a push or pull based model.
5252

5353
### Service-Level Objectives (SLOs)
@@ -113,7 +113,7 @@ then it MUST always set the result to `ok`.
113113
If the library is able to determine which function called the given function,
114114
then it MUST set the caller information in the `caller.function` and
115115
`caller.module` labels. If the caller is not known, either it is the entrypoint
116-
or the library is unable to determine the caller, then the `caller.function` and
116+
or the library is unable to determine the caller, in which case the `caller.function` and
117117
`caller.module` labels MAY be absent or empty (`""`).
118118

119119
### `function.calls.duration`
@@ -134,6 +134,7 @@ latency of function calls.
134134
| [`service.name`](#servicename) | required | |
135135
| [`objective.name`](#objectivename) | optional | if an [objective](#service-level-objectives-slos) is attached to the given function |
136136
| [`objective.percentile`](#objectivepercentile) | optional | if an [objective](#service-level-objectives-slos) is attached to the given function |
137+
| [`objective.latency_threshold`](#objectivelatency_threshold) | optional | if an [objective](#service-level-objectives-slos) is attached to the given function |
137138

138139
A library MUST track the duration in seconds.
139140

@@ -143,7 +144,7 @@ Library SHOULD allow the user to override these default buckets.
143144

144145
### `build_info`
145146

146-
A metrics that contains metadata related to the application. It should be
147+
A metric that contains metadata related to the application. It should be
147148
possible to join this metric with other metrics to enrich other metrics.
148149

149150
**Metric type:** Gauge

0 commit comments

Comments
 (0)