Skip to content

Commit 74f5889

Browse files
committed
Merge branch 'rejiggle_spec' into add_objective_name_guidelines_to_spec
2 parents 6d79673 + e54c48b commit 74f5889

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
This repo contains resources shared between all of the [Autometrics](https://github.com/autometrics-dev) implementations.
66

7-
## [Autometrics Specification](./SPEC.md)
7+
## [Autometrics Specification](./specs/autometrics_v1.0.0.md)
88

99
## Dashboards
1010

SPEC.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Autometrics Specification <!-- omit in toc -->
22

3+
** This spec is deprecated please see the new [versioned specs](./specs). **
4+
35
This is a work in progress specification for Autometrics.
46

57
It aims to describe the full feature set of the Autometrics libraries, but it may have important details missing. We will attempt to update this document to describe the expectations across all of the language implementations.

specs/autometrics_v1.0.0.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ A URL to the user's project git or other scm repository. This SHOULD be a URL
320320
that makes sense for the repository type. For example, for a git repository, it
321321
MAY be a HTTP URL or a SSH URL.
322322

323-
A library MUST use the value from the `AUTOMETRICS_REPOSITORY_URL` environment
323+
A library SHOULD use the value from the `AUTOMETRICS_REPOSITORY_URL` environment
324324
variable, if set. It SHOULD also allow for a value to be specified in the
325325
initialization function. A library MAY also attempt to determine the repository
326326
by itself, but the user MUST be able to opt-out of this behavior.
@@ -332,7 +332,7 @@ use this to provider deeper integration. The value MUST be a freeform string to
332332
allow users to specify their own values.
333333

334334
A library MAY try to parse the `repository.url` to determine the provider. It
335-
MUST allow the user to specify their own value using the
335+
SHOULD allow the user to specify their own value using the
336336
`AUTOMETRICS_REPOSITORY_PROVIDER` environment variable. The library MAY use the
337337
initialization function to override this value as well.
338338

@@ -345,4 +345,5 @@ initialization function to override this value as well.
345345
- Add `caller.module` label to `function.calls` metric
346346
- Rename `caller` label to `caller.function` in `function.calls` metric
347347
- Add `repository.url` and `repository.provider` labels to `build_info` metric
348-
- Add guidance on the `objective_name` label, and suggest to warn library users if they use anything other than alphanumeric characters, `_`, `-`, or a space
348+
- Add guidance on the `objective_name` label, and suggest to warn library users if they use anything other than alphanumeric characters, `_`, `-`, or a space
349+
- Relax requirements of environment variables from MUST to SHOULD

0 commit comments

Comments
 (0)