fix: fixes #76, adding more error checking and unifying calculation returns #86
Conversation
LouisBrunner
force-pushed
the
feature/better_calc
branch
2 times, most recently
from
56189a8 to
7972d44
Compare
| @@ -500,8 +526,7 @@ def calc_inverse_kinematics(self, guess, target_position, target_orientation, tc | |||
|
|
|||
| if r.status_code != 200: | |||
| eva_error('inverse_kinematics error', r) | |||
| return r.json() | |||
|
|
|||
| return self.__check_calculation(r, 'calc_inverse_kinematics', 'ik')['joints'] | |||
There was a problem hiding this comment.
for this 'calc_inverse_kinematics' and similar 'calc_forward_kinematics', 'calc_nudge' and 'calc_rotate' could use <function>.__name__?
There was a problem hiding this comment.
You mean like this?
return self.__check_calculation(r, self.calc_inverse_kinematics.__name__, 'ik')['joints']
There was a problem hiding this comment.
I meant like that yea, but now you typed it out seems a bit much ado about nothing... lol. Maybe enum would be nicer 🤷♂️. But I don't think this is important
LouisBrunner
force-pushed
the
feature/better_calc
branch
from
0f3efed to
53d747d
Compare
Codecov Report
@@ Coverage Diff @@
## development #86 +/- ##
===============================================
- Coverage 34.40% 34.40% -0.01%
===============================================
Files 11 11
Lines 805 808 +3
Branches 126 126
===============================================
+ Hits 277 278 +1
- Misses 520 522 +2
Partials 8 8
Continue to review full report at Codecov.
|
Remove the FK's
fk_type, add more error checking following 4.0.0's new calculation error format, make nudge/rotate/IK consistent in their return format.This is a breaking change.