Changing the manage submissions button to be ajax requests (#2271)

* fixing request bodies

* fixed disable buttons

* Fixing bugs

---------

Co-authored-by: Kester <kestertan040@gmail.com>

Author: dwang3851

app/assets/javascripts/manage_submissions.js

@@ -1,5 +1,8 @@
 const manage_submissions_endpoints = {
     'regrade-selected': 'regradeBatch',
+    'delete-selected': 'submissions/destroy_batch',
+    'download-selected': 'submissions/download_batch',
+    'excuse-selected': 'submissions/excuse_batch',
     'score_details': 'submissions/score_details',
 };
 
@@ -327,20 +330,73 @@ $(document).ready(function() {
     }
 
     function changeButtonStates(state) {
-      state ? buttonIDs.forEach((id) => $(id).addClass('disabled')) : buttonIDs.forEach((id) => $(id).removeClass('disabled'));
-
-      // prop each selected button with selected submissions
-      if (!state) {
-        var urlParam = $.param({'submission_ids': selectedSubmissions});
-        buttonIDs.forEach(function(id) {
-          var newHref = baseURLs[id] + '?' + urlParam;
-          $(id).prop('href', newHref);
-        });
-      } else {
-        buttonIDs.forEach(function(id) {
-          $(id).prop('href', baseURLs[id]);
-        });
-      }
+      buttonIDs.forEach((id) => {
+        const button = $(id);
+        if (state) {
+          if (id === "#download-selected") {
+            $(id).prop('href', baseURLs[id]);
+          }
+          button.addClass("disabled");
+          button.off("click").prop("disabled", true);
+        } else {
+          button.removeClass("disabled").prop("disabled", false);
+          if (id == "#download-selected") {
+            var urlParam = $.param({'submission_ids': selectedSubmissions});
+            buttonIDs.forEach(function(id) {
+              var newHref = baseURLs[id] + '?' + urlParam;
+              $(id).prop('href', newHref);
+            });
+            return;
+          }
+          $(document).off("click", id).on("click", id, function (event) {
+            console.log(`${id} button clicked`);
+            event.preventDefault();
+            if (selectedSubmissions.length === 0) {
+              alert("No submissions selected.");
+              return;
+            }
+            const endpoint = manage_submissions_endpoints[id.replace("#", "")];
+            const requestData = { submission_ids: selectedSubmissions };
+            if (id === "#delete-selected") {
+              if (!confirm("Deleting will delete all checked submissions and cannot be undone. Are you sure you want to delete these submissions?")) {
+                return;
+              }
+            }
+            let refreshInterval = setInterval(() => {
+              location.reload();
+            }, 5000);
+            $.ajax({
+              url: endpoint,
+              type: "POST",
+              contentType: "application/json",
+              data: JSON.stringify(requestData),
+              dataType: "json",
+              headers: {
+                "X-CSRF-Token": $('meta[name="csrf-token"]').attr("content"),
+              },
+              success: function (response) {
+                clearInterval(refreshInterval);
+                if (response.redirect) {
+                  window.location.href = response.redirect;
+                  return;
+                }
+                if (response.error) {
+                  alert(response.error);
+                }
+                if (response.success) {
+                  alert(response.success);
+                }
+                selectedSubmissions = [];
+                changeButtonStates(true);
+              },
+              error: function (error) {
+                clearInterval(refreshInterval);
+                alert("An error occurred while processing the request.");
+              },
+            });
+          });
+        }
+      });
     }
 
     changeButtonStates(true); // disable all buttons by default

app/controllers/assessment/autograde.rb

@@ -87,7 +87,19 @@ def regrade
   #
   # action_auth_level :regradeBatch, :instructor
   def regradeBatch
-    submission_ids = params[:submission_ids]
+    request_body = request.body.read
+    submission_ids = begin if request_body.present?
+                             parsed_data = JSON.parse(request_body)
+                         Array(parsed_data['submission_ids'])
+                       else
+                         params[:submission_ids]
+                       end
+                     rescue JSON::ParserError => e
+                       params[:submission_ids] || []
+                     end
+
+    # Ensure submission_ids is an array
+    submission_ids = Array(submission_ids)
 
     # Now regrade only the most recent submissions. Keep track of
     # any handins that fail.
@@ -129,7 +141,10 @@ def regradeBatch
     # For both :success and :error
     flash[:html_safe] = true
 
-    redirect_to([@course, @assessment, :submissions]) && return
+    respond_to do |format|
+      format.html { redirect_to [@course, @assessment, :submissions] }
+      format.json { render json: { redirect: url_for([@course, @assessment, :submissions]) } }
+    end
   end
 
   #

app/controllers/submissions_controller.rb

@@ -200,7 +200,9 @@ def destroy
   # remove a given submission for a student
   action_auth_level :destroy_batch, :instructor
   def destroy_batch
-    submission_ids = params[:submission_ids]
+    request_body = request.body.read
+    submission_ids = JSON.parse(request_body)['submission_ids']
+    submission_ids = Array(submission_ids)
     submissions = Submission.where(id: submission_ids)
     scount = 0
     fcount = 0
@@ -241,8 +243,10 @@ def destroy_batch
                                                       fcount, 'submission'
                                                     )} failed."
     end
-    redirect_to(course_assessment_submissions_path(submissions[0].course_user_datum.course,
-                                                   submissions[0].assessment)) && return
+    respond_to do |format|
+      format.html { redirect_to [@course, @assessment, :submissions] }
+      format.json { render json: { redirect: url_for([@course, @assessment, :submissions]) } }
+    end
   end
 
   # this is good
@@ -384,7 +388,9 @@ def tweak_total
 
   action_auth_level :excuse_batch, :course_assistant
   def excuse_batch
-    submission_ids = params[:submission_ids]
+    request_body = request.body.read
+    submission_ids = JSON.parse(request_body)['submission_ids']
+    submission_ids = Array(submission_ids)
     flash[:error] = "Cannot index submissions for nil assessment" if @assessment.nil?
 
     unless @assessment.valid?
@@ -434,7 +440,10 @@ def excuse_batch
 
     flash[:success] =
       "#{ActionController::Base.helpers.pluralize(auds_to_excuse.size, 'student')} excused."
-    redirect_to course_assessment_submissions_path(@course, @assessment)
+    respond_to do |format|
+      format.html { redirect_to [@course, @assessment, :submissions] }
+      format.json { render json: { redirect: url_for([@course, @assessment, :submissions]) } }
+    end
   end
 
   action_auth_level :unexcuse, :course_assistant

app/views/submissions/index.html.erb

@@ -97,36 +97,29 @@
 <%# Selected buttons, hidden so HTML can be accessed in DataTables %>
 <div class="selected-buttons-placeholder">
   <div id="regrade-batch-html">
-    <%= link_to "<i class='material-icons'>cached</i>Regrade Selected".html_safe,
-                regradeBatch_course_assessment_path(@course, @assessment),
-                { method: :post,
-                  title: "Regrade selected submissions",
-                  class: "btn submissions-selected" } %>
+    <%= link_to "Regrade Selected", class: "btn submissions-selected", title: "Regrade selected submissions" do %>
+      <i class="material-icons">cached</i> Regrade Selected
+    <% end %>
   </div>
 
   <div id="delete-batch-html">
-    <%= link_to "<i class='material-icons'>delete_outline</i>Delete Selected".html_safe,
-                destroy_batch_course_assessment_submissions_path(@course, @assessment, @submissions),
-                { method: :post,
-                  title: "Delete selected submissions",
-                  class: "btn submissions-selected",
-                  data: { confirm: "Deleting will delete all checked submissions and cannot be undone. Are you sure you want to delete these submissions?" } } %>
+    <a class="btn submissions-selected" title="Delete selected submissions">
+      <i class="material-icons">delete_outline</i>Delete Selected
+    </a>
   </div>
 
   <div id="download-batch-html">
     <%= link_to "<i class='material-icons'>download</i>Download Selected".html_safe,
                 download_batch_course_assessment_submissions_path(@course, @assessment, @submissions),
-                { method: :get,
+                { method: :post,
                   title: "Download selected submissions",
                   class: "btn submissions-selected" } %>
   </div>
 
   <div id="excuse-batch-html">
-    <%= link_to "<i class='material-icons'>done</i>Excuse Selected".html_safe,
-                excuse_batch_course_assessment_submissions_path(@course, @assessment, @submissions),
-                { method: :post,
-                  title: "Excuse selected submissions",
-                  class: "btn submissions-selected" } %>
+    <a class="btn submissions-selected" title="Excuse selected submissions">
+      <i class="material-icons">done</i>Excuse Selected
+    </a>
   </div>
 </div>
 

config/routes.rb

@@ -178,7 +178,7 @@
         collection do
           get "download_all"
           post "destroy_batch"
-          get "download_batch"
+          post "download_batch"
           get "popover"
           post "excuse_batch"
           post "unexcuse"