-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NET6 and IServiceProviderIsService support. #91
Conversation
…n't appear to work
Codecov Report
@@ Coverage Diff @@
## develop #91 +/- ##
===========================================
+ Coverage 92.74% 96.09% +3.35%
===========================================
Files 9 10 +1
Lines 124 128 +4
Branches 23 23
===========================================
+ Hits 115 123 +8
+ Misses 5 1 -4
Partials 4 4
Continue to review full report at Codecov.
|
…try the new CreateAsyncScope method while we're at it.
I figured out the problem with VS Code - OmniSharp only looks at the first item in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍇
Since this seems to be high visibility would it be worth putting a beta out on NuGet for folks to try? |
Seems like a good idea. Assuming you mean pushing 7.2.0-develop-00520 from MyGet to NuGet as 7.2.0-preview.1 or something? |
Exactly that. I can take care of it later if you don't have time, either way. |
I'll push it later, should only take a minute. I'll raise a GitHub preview release for it as well. |
Nuget package pushed, I'll post on that original runtime thread that it's available. |
Raising a PR to bring this in now the builds are passing, and .NET 6 Preview 6 has been released with
IServiceProviderIsService
available.I've made
AutofacServiceProvider
a partial class, and put the .NET 6 specific service on a partial in it's own file. Seemed like the cleanest way to add it.All the new specific tests added by the dotnet team that validate this new behaviour are passing.