Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AutofacServiceFactory: more new #11

Closed
wants to merge 1 commit into from

Conversation

marcrocny
Copy link

Submitted more as a commentary/reference to PR #10, this is a sketch of a more "consistent" version that replaces the function of AutofacServiceFactory outright.

Changes service-factory to return self if IServiceFactory is requested, and new-up a scope-factory when requested, rather than resolve. Also, don't resolve IServiceFactory in other contexts where new will suffice.

…ed, and `new`-up a scope-factory when requested, rather than resolve. Also, don't resolve `IServiceFactory` in other contexts where `new` will suffice.
@tillig
Copy link
Member

tillig commented Jul 19, 2017

As noted in PR #10 I think we'll add some extensions to Autofac.AspNetCore and include the StackOverflow workaround in an easy to consume way in that package. More details in #10. Huge thanks for taking this time and helping us think through the issue!

@tillig tillig closed this Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants