Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fixes #162

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Docs fixes #162

merged 5 commits into from
Oct 22, 2024

Conversation

QuantumChemist
Copy link
Collaborator

some corrections, adjustments and fixes of the documentation

  • add more documentation on the choice of the fitting parameter for the phonon workflow. maybe, provide the Si choice as a default or explain how to chose it
  • add documentation on how to allow users to adapt VASP settings more easily

@QuantumChemist
Copy link
Collaborator Author

QuantumChemist commented Oct 22, 2024

@JaGeo , here is the new PR.

If the issue with the stuck test is fixed and you are happy with the changes, we can merge this PR.

@JaGeo
Copy link
Collaborator

JaGeo commented Oct 22, 2024

I will merge once docs and linting are through. Then, we need to work on the tests

@QuantumChemist
Copy link
Collaborator Author

I will merge once docs and linting are through. Then, we need to work on the tests

Ok, now everything except the stuck test has passed. And in principle test split 5 passes as well as one could see in recent CI runs.

@JaGeo
Copy link
Collaborator

JaGeo commented Oct 22, 2024

There are some conflicts now. Could you resolve them, @QuantumChemist ?

@QuantumChemist
Copy link
Collaborator Author

There are some conflicts now. Could you resolve them, @QuantumChemist ?

solved! :)

@JaGeo JaGeo merged commit f2cd946 into autoatml:main Oct 22, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants