Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-urgent todos regarding the MLIPs in autoplex #77

Open
1 of 2 tasks
QuantumChemist opened this issue Jul 3, 2024 · 4 comments
Open
1 of 2 tasks

non-urgent todos regarding the MLIPs in autoplex #77

QuantumChemist opened this issue Jul 3, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@QuantumChemist
Copy link
Collaborator

QuantumChemist commented Jul 3, 2024

just want to note that the following changes should be done to improve the user experience with autoplex

  • automatic fit of separated and combined dataset for all MLIPs (now it's just implemented for GAP)
  • add default hyperparameter json file
@QuantumChemist QuantumChemist changed the title not urgent todos regarding the MLIPs in autoplex non-urgent todos regarding the MLIPs in autoplex Jul 3, 2024
@vlderinger
Copy link
Collaborator

Is this a pure enhancement, or are there questions about how we want to separate the datasets? (I'm asking so we can assign the right "label" to this issue)

@JaGeo
Copy link
Collaborator

JaGeo commented Nov 8, 2024

I think @QuantumChemist is referring to separation into single displaced supercells and random ones. This is a feature that might be useful for the phonon part

@QuantumChemist
Copy link
Collaborator Author

I think @QuantumChemist is referring to separation into single displaced supercells and random ones. This is a feature that might be useful for the phonon part

I mean this here. For now, one can only do the fit separately for single-atom-displaced, rattled supercells and the combined dataset for GAP: All the other MLIP can only use the combined dataset.

@vlderinger
Copy link
Collaborator

Ah! Yes it seems to me to make sense to let the user combine datasets, and to choose their MLIP framework, and to do both of these things independently from one another. (But not needed urgently I think)

@vlderinger vlderinger added the enhancement New feature or request label Nov 8, 2024
@QuantumChemist QuantumChemist linked a pull request Nov 29, 2024 that will close this issue
11 tasks
@QuantumChemist QuantumChemist self-assigned this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants