Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do NOT hide tab bar of tab-bar-mode when popup-menu* executeing. #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

khiker
Copy link

@khiker khiker commented May 9, 2024

Problem:

when popup-menu* is executed, popup-menu* hides tab bar when tab-bar-mode is t.

Expected:

when executing popup-menu*, do not hide tab bar if tab-bar-mode is t.

Reproduce:

(tab-bar-mode t) ;; -> show tab-bar
(require 'popup)
(popup-menu* '(a b)) ;; → hide tab-bar

Cause:

  1. popup-menu-read-key-sequence replaces current global-map to temp-global-map temporarily.
  2. temp-global-map do not have tab-bar's map.
  3. so, tab-bar disappears when popup-menu* executes.

Fix:

add tab-bar's map to temp-global-map same as menu-bar and tool-bar.

Environment;

Emacs 29.3
Debian GNU/Linux sid (6.7.12-amd64)

popup-el-and-tab-bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant