Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for a new maintainer #509

Closed
tarsius opened this issue May 5, 2020 · 42 comments
Closed

Looking for a new maintainer #509

tarsius opened this issue May 5, 2020 · 42 comments

Comments

@tarsius
Copy link
Contributor

tarsius commented May 5, 2020

auto-complete, popup-el and fuzzy-el are looking for new maintainers. If you are interested, then please say so.

Currently I am the "owner" of these repositories but I have only volunteered to do that so that these packages can be handed over smoothly once we have found some volunteers. I am not qualified myself because I have never even just used these packages.

@dickmao
Copy link

dickmao commented May 5, 2020

You can add me.

@NotMoni
Copy link

NotMoni commented May 6, 2020

@tarsius Hey mate, I currently maintain Node-Fetch and would be happy to help. You can count me in. 🦄

@tarsius
Copy link
Contributor Author

tarsius commented May 9, 2020

Hey @dickmao and @NotMoni, thanks for offering your help!

Could you please say a few words about your experience maintaining elisp packages and also what kind of help you can and intend to offer here.

I intend to review all commits for a while at least. Past experience has shown that I might have to intervene occasionally but I'll try hard to stay out of your way.

@NotMoni
Copy link

NotMoni commented May 9, 2020

Hey, @tarsius I am a nodeJS dev, but i can review basic pr and common issues.

@tarsius
Copy link
Contributor Author

tarsius commented May 13, 2020

@NotMoni I was really hoping for an experienced elisp developer but issue triage is also useful.

You already have the necessary permissions, feel free to begin work. 😁

I had a quick look and feel that many old issues can be closed. It's probably best if you provide a one sentence for why you close an issue, except in extreme cases such as #481.

@dickmao
Copy link

dickmao commented May 17, 2020

I sent emails to the address listed on your github profile, and I suspect they went to spam.

Could you re-extend the Collaborator invite? The first one seems to have expired.

@dickmao
Copy link

dickmao commented May 17, 2020

Thanks. I generally work best with full Admin access, however.

@dickmao dickmao closed this as completed May 17, 2020
@tarsius
Copy link
Contributor Author

tarsius commented May 17, 2020

I sent emails to the address listed on your github profile, and I suspect they went to spam.

I got your messages but I did not fully understand your first message and was a bit busy at the time so I put of replying. I understood what you said (I believe) but I was confused as to whether that meant that you did not want help maintain auto-complete after all. You had also let the invitation to this repo run out by then so I assumed that that was what it meant.

You talked about the value you see in auto-complete and how it relates to company-mode. This is of interest to other people as well, since they might want to know how the maintainers feel about the package. I think you should post that or something similar here.

@tarsius
Copy link
Contributor Author

tarsius commented May 17, 2020

Thanks. I generally work best with full Admin access, however.

I would like to wait with that for a while and review all changes. In the past I have given more far reaching access right away and that did not always work out so well.

@tarsius
Copy link
Contributor Author

tarsius commented May 17, 2020

You are not closing every issue right now, are you?

@dickmao
Copy link

dickmao commented May 17, 2020

You are not closing every issue right now, are you?

No, some cling to relevancy, but just barely.

@tarsius
Copy link
Contributor Author

tarsius commented May 17, 2020

You should have discussed this with me first. I would have asked you to use a less aggressive (close fewer issues), more careful (spend more time investigating each issue, twenty seconds is not enough), and more explicit (above I already asked for a short explanation in most cases) approach.

@asmeurer
Copy link
Contributor

I agree. Several issues I was following were closed without explanation, or simply because "I don't plan to work on this" (but why not just leave them open in case someone else does?).

@tarsius tarsius reopened this May 17, 2020
@dickmao
Copy link

dickmao commented May 17, 2020

I'll reopen the issues.

@tarsius
Copy link
Contributor Author

tarsius commented May 17, 2020

No, it's okay.

I would probably have closed the majority of these issues myself but I would have provided a short justification in more cases. Closing many issues wasn't necessarily wrong considering that past maintainers have done a very bad job closing resolved issues and issues that are certain not to lead anywhere.

A few of these issues shouldn't have been closed, but now that they are closed we can leave them closed. Reopening issues that should remain closed also wouldn't be desirable.

If someone feels that a particular issues should be reopened, then they just have to ask.

@tarsius
Copy link
Contributor Author

tarsius commented May 17, 2020

@dickmao I just told you to NOT reopen the issues.

@dickmao
Copy link

dickmao commented May 17, 2020

Very sorry! I didn't get your message in time!

Well, I guess we're in no worse a state than we were four hours ago.

@tarsius
Copy link
Contributor Author

tarsius commented May 17, 2020

Very sorry! I didn't get your message in time!

This is now the second time that you just acted without giving someone else a few minutes to react first. You might want to avoid that in the future.

Well, I guess we're in no worse a state than we were four hours ago.

I disagree. This is worse than a few hours ago. Going forward I will not only hesitate to give someone write access but even just triage rights.

Well, I think this is goodby. This and #510 does not look like this project is going to get any useful contributions from you. I feel a bit bad saying it like this but I don't want to waste any time on this either.

@NotMoni
Copy link

NotMoni commented May 20, 2020

@dickmao Bro chilll 😐

@jcs090218
Copy link
Member

@tarsius Can I maintain popup.el? Since my config and some of my packages are rely on this package, I would like to maintain this package to just in case it doesn't break in the future and also keep the package as stable as possible! Thanks! :)

@tarsius
Copy link
Contributor Author

tarsius commented May 28, 2020

I've invited you to the organization. Once you have accepted that I can assign you to the repository.

@jcs090218
Copy link
Member

Joined! Thanks for the invite! :)

@jcs090218
Copy link
Member

I may have time for this package now! I am not too confident to maintain this package since the code base is quite complicated and not modular. But I would still like to give this package a try, and maybe start reading some code base and do basic review PRs; answering issue, etc.

@tarsius Can you assign me to this repo? Thanks! 😁

@jcs090218
Copy link
Member

@tarsius Ping! You there? :)

@tarsius
Copy link
Contributor Author

tarsius commented Sep 30, 2020

Slightly busy.

I've given you access now.

@jcs090218
Copy link
Member

Thanks! Sorry for pinging you while you are busy!

@tarsius
Copy link
Contributor Author

tarsius commented Oct 1, 2020

Naaa, that's okay.

@tarsius
Copy link
Contributor Author

tarsius commented Oct 1, 2020

@NotMoni are you actually doing any triaging? Asking because you have the rights to do so. 😉

@jcs090218 jcs090218 pinned this issue Nov 8, 2020
@tarsius
Copy link
Contributor Author

tarsius commented Mar 16, 2021

@jcs090218 I just made you a maintainer of the other two repositories (fuzzy and the webpage).

@jcs090218
Copy link
Member

Ah, okay! Thanks! :)

@NotMoni
Copy link

NotMoni commented Mar 17, 2021

@NotMoni are you actually doing any triaging? Asking because you have the rights to do so. 😉

Hey, I've had some other major changes in my life. I won't be able to triage, you can remove me. Sorry.

@tarsius
Copy link
Contributor Author

tarsius commented Mar 17, 2021

@NotMoni No problem. All the best to you!

@tarsius
Copy link
Contributor Author

tarsius commented Dec 8, 2021

Hey @jcs090218,

By mail @piotrklibert volunteered to become another maintainer. He doesn't have experience maintaining elisp packages but otherwise has a lot of experience with lisps and such. I think he would make a nice addition to the team. I told him it would be best to work with pull-requests initially but am inclined to give him commit access soon. But of course since nowadays you do all the work around here you get to decide how we proceed.

@jcs090218
Copy link
Member

Sounds good to me!

TBH, I have less and less activities for this package nowadays. It's always great to have people step up as a co-maintainer. :)

@piotrklibert
Copy link
Collaborator

Hello guys, nice to meet you!

First, I wrote my mail before I read this thread to the bottom... That was a mistake - I didn't know that the maintainer was already decided, so I wrote that I would like to be one. I tried to sound confident, but to be honest, I wasn't 100% sure I could do it, as I have no experience with maintaining popular open-source packages - none at all. I was also worried about how much time I'll be able to reserve for the project. I think becoming a co-maintainer (instead of a sole maintainer) will help on both fronts, so I'm delighted that you consider me for that position :)

With that out of the way: I'm currently sick, but getting better already, so I think I'll be able to set a few h aside during the weekend. Where should I start? I have a few immediate itches I'd like to scratch, but I need to do some research before taking care of them. I can help with whatever is needed the most in the meantime :)

Finally, there's a link to my blog in my profile - a quick glance should give you (@jcs090218) an overview of what I'm interested in and what I happened to work on (outside of my day job, I mean). I'll also happily answer if you have any questions! :)

@jcs090218
Copy link
Member

jcs090218 commented Dec 10, 2021

I reckon there are not too many things to do since this package has been inactive for such a long time (4 to 5 years?). I am only baby sit the package by fixing basic bugs and make sure it compatible to newer version of Emacs, etc.

I don't think we are going to continue develop this package, so anything else like read through the code and improve the documentation may help a lot for people to get on track on what's going on to this repo. Other than that, is to review PRs and answering questions in the ISSUE tab.

there's a link to my blog in my profile

It seems like you know a lot of programming languages, maybe PR like #492 would be greatly appreciated! ❤️

You might also want to read through some guidelines like MakingPackages from EmacsWiki, so you know what you should do to create a package. And make sure you don't break it while maintaining it. :)

Hope these information helps!

@tarsius tarsius unpinned this issue Dec 22, 2021
@tarsius
Copy link
Contributor Author

tarsius commented Aug 22, 2022

@jcs090218 I just made you an "owner" of this organization.

In a second step I would like to step down as a owner myself.

@jcs090218
Copy link
Member

Thanks! @tarsius

Feel free to leave this organization to me if you feel comfortable with it (or just step down as a owner)! I think we can keep this issue open since I am also NOT very active to this org, and maybe could find other potential maintainers! 😅 👍

@tarsius
Copy link
Contributor Author

tarsius commented Aug 22, 2022

Great! Things have been running smoothly with you at the helm and I have no reason to doubt it will stay that way. If you find someone who wants to move this package forward that would be nice, but it seems to be doing fine in maintenance mode.

Cheers!

@theunixman
Copy link

I'm available to help maintain and possibly start adding features to this package. I've worked on my own private elisp modes and minor modes for awhile now, I've got my (not well-organized) startup files available for review as well. I've worked with text searching algorithms, NLP in general, and deep neural networks in the past too for what that's worth.

@jcs090218
Copy link
Member

Awesome, it's great to have additional maintainers! Have you developed at least one package and published it to GNU Elpa or MELPA? I think it would be great if you have this experience in maintaining an elisp package. But for the bare minimum, you can start off by answering issues, reviewing PRs, etc.

@theunixman
Copy link

I've worked with local elisp packages, but I haven't uploaded anything yet. I'm happy to help with issues and PRs too.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants