Skip to content

Commit 6707fde

Browse files
panvajulienwoll
authored andcommitted
Improve secret handling in SignStream
Refactor secret assignment logic in SignStream constructor.
1 parent 7d4a071 commit 6707fde

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

lib/sign-stream.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,12 @@ function jwsSign(opts) {
3434
}
3535

3636
function SignStream(opts) {
37-
var secret = opts.secret||opts.privateKey||opts.key;
37+
var secret = opts.secret;
38+
secret = secret == null ? opts.privateKey : secret;
39+
secret = secret == null ? opts.key : secret;
40+
if (/^hs/i.test(opts.header.alg) === true && secret == null) {
41+
throw new TypeError('secret must be a string or buffer or a KeyObject')
42+
}
3843
var secretStream = new DataStream(secret);
3944
this.readable = true;
4045
this.header = opts.header;

0 commit comments

Comments
 (0)