Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types should be in "devDependencies" #428

Open
4 tasks done
iSuslov opened this issue Nov 10, 2024 · 0 comments
Open
4 tasks done

Types should be in "devDependencies" #428

iSuslov opened this issue Nov 10, 2024 · 0 comments
Labels

Comments

@iSuslov
Copy link

iSuslov commented Nov 10, 2024

Checklist

  • I have looked into the Readme and Examples, and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.

Description

Type packages should be in dev dependencies. npm prune and other similar tools does not delete it and it has overhead when deploying an application.

I can see that it was addressed once #91 but then it back again.

Since this package is used extensively by popular libraries would be very nice to have it fixed

Reproduction

Check package.json

https://github.com/auth0/node-jwks-rsa/blob/c4767cd2b1048a24f567b86f5f6b732507d0635d/package.json#L15C6-L16

Additional context

No response

jwks-rsa version

latest

Node.js version

all

@iSuslov iSuslov added the bug label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant