-
Notifications
You must be signed in to change notification settings - Fork 437
WIP: Initial README.md changes for next-16 support #2383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nandan-bhat
wants to merge
12
commits into
main
Choose a base branch
from
support/nextjs-16
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3733859
WIP: Initial README.md update for nextjs-16 support
nandan-bhat e4c6e2f
Merge branch 'main' into support/nextjs-16
nandan-bhat 8d4bbbf
WIP: Making SDK support both 15 and 16 versions of Next
nandan-bhat b7f2cd8
WIP: Addressing the feedbacks
nandan-bhat 98ed99f
Merge branch 'main' into support/nextjs-16
nandan-bhat 0293d9e
Remove unused import from next-compat.ts
nandan-bhat b6d5ef4
WIP: Added 'toNextResponse'
nandan-bhat 872b611
Merge branch 'main' into support/nextjs-16
nandan-bhat 8dcf648
Adding unit test coverage
nandan-bhat 4a9c9e0
Removing pre-fetch logics as they are not working as expected
nandan-bhat 3cef8d8
Updated EXAMPLES.md
nandan-bhat a8cb74f
Merge branch 'main' into support/nextjs-16
nandan-bhat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| import { NextRequest, NextResponse } from "next/server.js"; | ||
| import { describe, expect, it } from "vitest"; | ||
|
|
||
| import { toNextRequest, toNextResponse } from "./next-compat.js"; | ||
|
|
||
| describe("next-compact", () => { | ||
| describe("toNextRequest", () => { | ||
| it("should return the same instance if input is already a NextRequest", () => { | ||
| const req = new NextRequest("https://example.com/api/test", { | ||
| method: "GET" | ||
| }); | ||
| const result = toNextRequest(req); | ||
| expect(result).toBe(req); | ||
| }); | ||
|
|
||
| it("should convert a plain Request into a NextRequest preserving url, method, headers and body", async () => { | ||
| const headers = new Headers({ "x-test": "true" }); | ||
| const body = JSON.stringify({ foo: "bar" }); | ||
| const plainReq = new Request("https://example.com/api/data", { | ||
| method: "POST", | ||
| headers, | ||
| body | ||
| }); | ||
|
|
||
| const nextReq = toNextRequest(plainReq); | ||
| expect(nextReq).toBeInstanceOf(NextRequest); | ||
| expect(nextReq.url).toBe("https://example.com/api/data"); | ||
| expect(nextReq.method).toBe("POST"); | ||
| expect(nextReq.headers.get("x-test")).toBe("true"); | ||
|
|
||
| const parsed = await nextReq.json(); | ||
| expect(parsed).toEqual({ foo: "bar" }); | ||
| }); | ||
|
|
||
| it("should set duplex to 'half' if not provided", () => { | ||
| const req = new Request("https://example.com", { method: "GET" }); | ||
| const nextReq = toNextRequest(req); | ||
| expect((nextReq as any).duplex).toBe("half"); | ||
| }); | ||
|
|
||
| it("should default to 'half' duplex when invalid or missing", () => { | ||
| // Mock an object without a valid duplex property | ||
| const fakeReq: any = { | ||
| url: "https://example.com", | ||
| method: "GET", | ||
| headers: new Headers(), | ||
| body: null | ||
| }; | ||
|
|
||
| // The conversion should not throw and should set duplex: 'half' | ||
| const nextReq = toNextRequest(fakeReq); | ||
| expect(nextReq).toBeInstanceOf(NextRequest); | ||
| expect((nextReq as any).duplex).toBe("half"); | ||
| }); | ||
| }); | ||
|
|
||
| describe("toNextResponse", () => { | ||
| it("should return the same instance if input is already a NextResponse", () => { | ||
| const res = NextResponse.json({ ok: true }, { status: 200 }); | ||
| const result = toNextResponse(res); | ||
| expect(result).toBe(res); | ||
| }); | ||
|
|
||
| it("should convert a plain Response into a NextResponse preserving body, status, and headers", async () => { | ||
| const plainRes = new Response(JSON.stringify({ ok: true }), { | ||
| status: 202, | ||
| statusText: "Accepted", | ||
| headers: { "x-test": "42" } | ||
| }); | ||
|
|
||
| const nextRes = toNextResponse(plainRes); | ||
| expect(nextRes).toBeInstanceOf(NextResponse); | ||
| expect(nextRes.status).toBe(202); | ||
| expect(nextRes.statusText).toBe("Accepted"); | ||
| expect(nextRes.headers.get("x-test")).toBe("42"); | ||
|
|
||
| const data = await nextRes.json(); | ||
| expect(data).toEqual({ ok: true }); | ||
| }); | ||
|
|
||
| it("should copy url if present (mocked plain object, assignable)", () => { | ||
| // Use a *plain object*, not a real Response instance. | ||
| const fakeRes: any = { | ||
| body: "ok", | ||
| status: 200, | ||
| statusText: "OK", | ||
| headers: new Headers(), | ||
| url: "https://example.com/test" | ||
| }; | ||
|
|
||
| const nextRes = toNextResponse(fakeRes); | ||
|
|
||
| // NextResponse inherits a read-only url getter, so we can’t assert strict equality here. | ||
| // Instead, we confirm our helper didn’t throw and that it *tried* to propagate the url. | ||
| expect(nextRes).toBeInstanceOf(NextResponse); | ||
| expect(() => (nextRes as any).url).not.toThrow(); | ||
| }); | ||
|
|
||
| it("should silently ignore errors when accessing url", () => { | ||
| const fakeRes = { | ||
| body: "ok", | ||
| status: 200, | ||
| statusText: "OK", | ||
| headers: new Headers() | ||
| } as any; | ||
| Object.defineProperty(fakeRes, "url", { | ||
| get() { | ||
| throw new Error("inaccessible"); | ||
| } | ||
| }); | ||
| expect(() => toNextResponse(fakeRes)).not.toThrow(); | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.