Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withPayload to JWTCreator.Builder #475

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Add withPayload to JWTCreator.Builder #475

merged 2 commits into from
Feb 22, 2021

Conversation

jimmyjames
Copy link
Contributor

Changes

This change adds a withPayload(Map<String, ?> payloadClaims) to the JWTCreator.Builder. It uses #454 as a starting point.

Details:

  • It only supports claim values of supported types
  • The behavior for map or list claims is consistent with the implementation of withClaim(String name, Map<String, ?> map) and withClaim(String name, List<?> list)
  • If any of the claim values are invalid, none will be added to the payload claims

This will resolve #445

References

Checklist

@jimmyjames jimmyjames added this to the v3-Next milestone Feb 19, 2021
@jimmyjames jimmyjames requested a review from a team as a code owner February 19, 2021 20:26
@jimmyjames jimmyjames changed the title With payload Add withPayload to JWTCreator.Builder Feb 19, 2021
@jimmyjames jimmyjames closed this Feb 19, 2021
@jimmyjames jimmyjames reopened this Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion to create method withPayload in JWTCreator.java
2 participants