Exposed protected Transaction data
#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjvmroz
changed the title
mjvmroz
changed the title
protected Transaction data
hzalaz
approved these changes
Mar 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library is largely unopinionated, to the point that it does not even expose its own HTTP client's async types. The dependency on Java's
Serializablecontradicts this sentiment, and I'm keen to see it removed.The aim of this PR is to make available to developers the information associated with a
Transactionto avoid the necessity of serializing it through a poor mechanism. Correspondingly,Guardian#confirmEnroll(String, String)has been added as an overload onGuardian#confirmEnroll(Transaction, String)to represent more accurately what information is necessary for the method to succeed.