GuardianException: add isTransactionNotFound

Author: nikolaseu

src/main/java/com/auth0/guardian/GuardianException.java

@@ -35,6 +35,7 @@ public class GuardianException extends RuntimeException {
     private static final String ERROR_DEVICE_ACCOUNT_NOT_FOUND = "device_account_not_found";
     private static final String ERROR_ENROLLMENT_NOT_FOUND = "enrollment_not_found";
     private static final String ERROR_LOGIN_TRANSACTION_NOT_FOUND = "login_transaction_not_found";
+    private static final String ERROR_TRANSACTION_NOT_FOUND = "transaction_not_found";
 
     private static final String ERROR_ALREADY_ENROLLED = "already_enrolled";
 
@@ -106,6 +107,15 @@ public boolean isLoginTransactionNotFound() {
         return ERROR_LOGIN_TRANSACTION_NOT_FOUND.equals(errorCode);
     }
 
+    /**
+     * Whether the error is caused by the transaction being invalid, expired or not found (e.g. already confirmed)
+     *
+     * @return true if error is caused by the transaction being invalid, expired or not found
+     */
+    public boolean isTransactionNotFound() {
+        return ERROR_TRANSACTION_NOT_FOUND.equals(errorCode);
+    }
+
     /**
      * Whether the error is caused by the user already having a confirmed enrollment
      *

src/test/java/com/auth0/guardian/APIClientTest.java

@@ -215,6 +215,24 @@ public void shouldThrowLoginTransactionNotFound() throws Exception {
         }
     }
 
+    @Test
+    public void shouldThrowTransactionNotFound() throws Exception {
+        exception.expect(GuardianException.class);
+        exception.expectMessage("Not found");
+
+        server.jsonResponse(MockServer.ERROR_TRANSACTION_NOT_FOUND, 400);
+
+        try {
+            apiClient
+                    .verifyOTP(TRANSACTION_TOKEN, OTP_CODE)
+                    .execute();
+        } catch (GuardianException e) {
+            assertThat(e.getErrorCode(), is(equalTo("transaction_not_found")));
+            assertThat(e.isTransactionNotFound(), is(equalTo(true)));
+            throw e;
+        }
+    }
+
     @Test
     public void shouldThrowInvalidOTP() throws Exception {
         exception.expect(GuardianException.class);

src/test/java/com/auth0/guardian/MockServer.java

@@ -47,6 +47,7 @@ public class MockServer {
     public static final String ERROR_DEVICE_ACCOUNT_NOT_FOUND = "src/test/resources/error_code_device_account_not_found.json";
     public static final String ERROR_ENROLLMENT_NOT_FOUND = "src/test/resources/error_code_enrollment_not_found.json";
     public static final String ERROR_LOGIN_TRANSACTION_NOT_FOUND = "src/test/resources/error_code_login_transaction_not_found.json";
+    public static final String ERROR_TRANSACTION_NOT_FOUND = "src/test/resources/error_code_transaction_not_found.json";
     public static final String ERROR_INVALID_TOKEN = "src/test/resources/error_code_invalid_token.json";
 
     private final MockWebServer server;

src/test/resources/error_code_transaction_not_found.json

@@ -0,0 +1,4 @@
+{
+  "error": "Not found",
+  "errorCode": "transaction_not_found"
+}