fix no worker node error on multi-node cluster (opensearch-project#1487) (opensearch-project#1513)

opensearch-trigger-bot[bot] · ylwu-amzn · austin-aryn-ai · commit 7b76e780b9f8 · 2024-02-29T15:50:34.000-08:00
Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit cea1cd6) Co-authored-by: Yaliang Wu <ylwu@amazon.com>
diff --git a/plugin/src/main/java/org/opensearch/ml/action/prediction/TransportPredictionTaskAction.java b/plugin/src/main/java/org/opensearch/ml/action/prediction/TransportPredictionTaskAction.java
@@ -121,9 +121,8 @@ public void onFailure(Exception e) {
 
             if (cachedMlModel != null) {
                 modelActionListener.onResponse(cachedMlModel);
-            } else if (modelAccessControlHelper.skipModelAccessControl(user)) {
-                executePredict(mlPredictionTaskRequest, wrappedListener, modelId);
             } else {
+                // For multi-node cluster, the function name is null in cache, so should always get model first.
                 mlModelManager.getModel(modelId, modelActionListener);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -121,9 +121,8 @@ public void onFailure(Exception e) {`
`121`	`121`
`122`	`122`	`if (cachedMlModel != null) {`
`123`	`123`	`modelActionListener.onResponse(cachedMlModel);`
`124`		`- } else if (modelAccessControlHelper.skipModelAccessControl(user)) {`
`125`		`- executePredict(mlPredictionTaskRequest, wrappedListener, modelId);`
`126`	`124`	`} else {`
	`125`	`+ // For multi-node cluster, the function name is null in cache, so should always get model first.`
`127`	`126`	`mlModelManager.getModel(modelId, modelActionListener);`
`128`	`127`	`}`
`129`	`128`	`}`