Build and PHPMD fixes

Author: renatocason

.gitignore

@@ -1,4 +1,4 @@
-composer.lock
-marketplace-eqp/
-Test/Unit/logs/
-vendor/
+/composer.lock
+/magento-coding-standard/
+/Test/Unit/logs/
+/vendor/

.travis.yml

@@ -5,15 +5,16 @@ language: php
 php:
     - 7.1
     - 7.2
+    - 7.3
 
 install:
     - mkdir -p ~/.composer/
     - echo "{\"http-basic\":{\"repo.magento.com\":{\"username\":\"${MAGENTO_USERNAME}\",\"password\":\"${MAGENTO_PASSWORD}\"}}}" > ~/.composer/auth.json
     - composer install --prefer-dist
-    - composer create-project --repository=https://repo.magento.com magento/marketplace-eqp marketplace-eqp
+    - composer create-project magento/magento-coding-standard magento-coding-standard
 
 script:
-    - php marketplace-eqp/vendor/bin/phpcs Model/ Test/  --standard=MEQP2 --severity=10
+    - php magento-coding-standard/vendor/bin/phpcs Model/ Test/ --standard=Magento2 --severity=10
     - php vendor/bin/phpmd Model/,Test text cleancode,codesize,controversial,design,naming,unusedcode --ignore-violations-on-exit
     - php vendor/phpunit/phpunit/phpunit --coverage-clover Test/Unit/logs/clover.xml Test
 

Model/CatalogUrlRewrite/ProductUrlRewriteGenerator.php

@@ -17,6 +17,7 @@
 use Magento\Store\Model\StoreManagerInterface;
 
 /**
+ * @SuppressWarnings(PHPMD.LongVariable)
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ProductUrlRewriteGenerator extends \Magento\CatalogUrlRewrite\Model\ProductUrlRewriteGenerator
@@ -30,8 +31,6 @@ class ProductUrlRewriteGenerator extends \Magento\CatalogUrlRewrite\Model\Produc
      * Generates url rewrites for different scopes.
      * 
      * @var ProductScopeRewriteGenerator
-     * 
-     * @SuppressWarnings(PHPMD.LongVariable)
      */
     private $productScopeRewriteGenerator;
 
@@ -44,7 +43,6 @@ class ProductUrlRewriteGenerator extends \Magento\CatalogUrlRewrite\Model\Produc
      * @param \Magento\Store\Model\StoreManagerInterface $storeManager
      * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
      * 
-     * @SuppressWarnings(PHPMD.LongVariable)
      * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(

Test/Unit/Model/CatalogUrlRewrite/ProductUrlRewriteGeneratorTest.php

@@ -2,6 +2,7 @@
 
 namespace Aune\ProductCategoryUrlFix\Test\Unit\Model\CatalogUrlRewrite;
 
+use ReflectionClass;
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
 use Magento\Catalog\Model\Product;
@@ -110,7 +111,7 @@ protected function setUp()
         );
 
         // Inject private property to avoid ObjectManager error
-        $reflection = new \ReflectionClass(get_class($this->productUrlRewriteGenerator));
+        $reflection = new ReflectionClass(get_class($this->productUrlRewriteGenerator));
         $reflectionProperty = $reflection->getProperty('productScopeRewriteGenerator');
         $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($this->productUrlRewriteGenerator, $this->productScopeRewriteGenerator);

Test/Unit/bootstrap.php

@@ -1,14 +1,16 @@
 <?php
 
-// @codingStandardsIgnoreFile
+/**
+ * @codingStandardsIgnoreFile
+ * @SuppressWarnings(PHPMD)
+ */
 
 require_once realpath(__DIR__ . '/../../vendor/autoload.php');
 
 if (!function_exists('__')) {
     /**
      * Create value-object \Magento\Framework\Phrase
      * 
-     * @SuppressWarnings(PHPMD.ShortMethodName)
      * @return \Magento\Framework\Phrase
      */
     function __()