[OperationalInsights] bug fix - PSStorageInsight failed on null value of containers and tables (Azure#16860)

* fixed a bug that caused an exception when creating PSStorageInsight object

* removed commentns and added null check

* changelog update

Author: dabenhamMic

src/OperationalInsights/OperationalInsights/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Bug fix - prevent exceptions while using StorageInsight cmdlets 
 
 ## Version 3.0.0
 * Expanded DataSourceType with values `Query`, `Alerts` for LinkedStorageAccount cmdlets

src/OperationalInsights/OperationalInsights/Models/PSStorageInsight.cs

@@ -37,8 +37,8 @@ public PSStorageInsight(StorageInsight storageInsight, string resourceGroupName,
             this.Type = storageInsight.Type;
             this.StorageAccountResourceId = storageInsight.StorageAccount?.Id;
             this.StorageAccountKey = storageInsight.StorageAccount?.Key;
-            this.Tables = storageInsight.Tables.ToList();
-            this.Containers = storageInsight.Containers.ToList();
+            this.Tables = storageInsight.Tables?.ToList();
+            this.Containers = storageInsight.Containers?.ToList();
             this.State = storageInsight.Status?.State;
             this.StateDescription = storageInsight.Status?.Description;
             this.ETag = storageInsight.ETag;
@@ -53,22 +53,22 @@ public PSStorageInsight(StorageInsight storageInsight, string resourceGroupName,
 
         public string WorkspaceName { get; set; }
 
-        public string Type { get; set; }//added
+        public string Type { get; set; }
 
         public string StorageAccountResourceId { get; set; }
 
-        public string StorageAccountKey { get; set; }// new prop
+        public string StorageAccountKey { get; set; }
 
         public string State { get; set; }
 
-        public string StateDescription { get; set; }//new prop
+        public string StateDescription { get; set; }
 
         public List<string> Tables { get; set; }
 
         public List<string> Containers { get; set; }
 
-        public Hashtable Tags { get; set; } //new prop
+        public Hashtable Tags { get; set; }
 
-        public string ETag { get; set; }//new prop
+        public string ETag { get; set; }
     }
 }