Add YAML as an option for context files. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for both JSON and YAML files.
information as well as empty yaml file.
|
Yeah thinking about it, it's probably better to have json parsed by the json module. Changed that back and added tests for yaml files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation here is that YAML is easier for human reading/editing especially with regards to convenience factors such as comments and not having to quote keys. Implemented using PyYAML since this package is already a requirement for the config file. Uses PyYAML to parse both .json and .yaml/.yml files since YAML is a superset of JSON (if this is not true of PyYAML and the standard json library it is an easy fix). I'm assuming here that the speed cost is going to be negligible on most projects since YAML parsing is typically slower than JSON.
As a side note, this change also fixes bug #26 since PyYAML gracefully ignores empty files.