http.Service parseAddress Is the path of the beacon node intercepted, causing some nodes to be inaccessible?

[duktig666]

go-eth2-client/http/service.go

Lines 397 to 426 in 951cf2c

	func parseAddress(address string) (*url.URL, *url.URL, error) {
	if !strings.HasPrefix(address, "http") {
	address = fmt.Sprintf("http://%s", address)
	}
	base, err := url.Parse(address)
	if err != nil {
	return nil, nil, errors.Join(errors.New("invalid URL"), err)
	}
	// Remove any trailing slash from the path.
	base.Path = strings.TrimSuffix(base.Path, "/")
	// Attempt to mask any sensitive information in the URL, for logging purposes.
	baseAddress := *base
	if _, pwExists := baseAddress.User.Password(); pwExists {
	// Mask the password.
	user := baseAddress.User.Username()
	baseAddress.User = url.UserPassword(user, "xxxxx")
	}
	if baseAddress.Path != "" {
	// Mask the path.
	baseAddress.Path = "xxxxx"
	}
	if baseAddress.RawQuery != "" {
	// Mask all query values.
	sensitiveRegex := regexp.MustCompile("=([^&]*)(&)?")
	baseAddress.RawQuery = sensitiveRegex.ReplaceAllString(baseAddress.RawQuery, "=xxxxx$2")
	}
	return base, &baseAddress, nil
	}

        if baseAddress.Path != "" {
		// Mask the path.
		baseAddress.Path = "xxxxx"
	}

The above code intercepts the path configured beaconAddr, which makes some normal nodes inaccessible.

For example, the following nodes:

https://aaa.com/ethereum2/{token}

It is normal for paths to carry tokens, but such modifications invalidate them.

[Bez625]

Hi @duktig666

I took a look at the code you mentioned and I think there is a slight misunderstanding in it's purpose. The function returns two variables; base and baseAddress. base is largely unmodified and is used to connect to the address supplied. As you point out, baseAddress is modified to mask any sensitive information, but should only be used for logs and monitoring purposes.

It might help if you can explain the issue you are seeing related to this? E.g. which URL are you trying to connect to and what is the error message you are getting? Feel free to share some logs (with sensitive information redacted of course).

[YFiN99]

gm