feat: Bump MSRV to 1.85 #336
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the Minimum Supported Rust Version (MSRV) from 1.75.0 to 1.85.0 to resolve dependency compatibility issues. The changes include CI workflow updates, WASM target modernization, dependency updates, and automatic code formatting fixes applied by the newer Rust version.
Key changes:
- Updated MSRV from 1.75.0 to 1.85.1 with edition 2024
- Modernized WASM targets from deprecated
wasm32-wasitowasm32-wasip1andwasm32-wasip2 - Applied automatic formatting changes (import reordering, line wrapping) from newer rustfmt
Reviewed changes
Copilot reviewed 81 out of 83 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
rust-toolchain.toml |
Updated toolchain version from 1.75.0 to 1.85.1 |
.github/workflows/rust.yml |
Updated MSRV test from 1.75.0 to 1.85.0 |
.github/workflows/wasm.yml |
Replaced deprecated wasm32-wasi with wasm32-wasip1 and wasm32-wasip2 |
Cargo.toml |
Updated edition to 2024, MSRV to 1.85, pinned generic-array to 0.14.7, removed unused dependencies |
bsky-sdk/Cargo.toml |
Removed unused dependency specifications |
atrium-oauth/Cargo.toml |
Removed unused base64ct dependency |
atrium-crypto/Cargo.toml |
Added explicit generic-array dependency |
Multiple .rs files |
Applied automatic rustfmt import reordering and line length formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the Minimum Supported Rust Version (MSRV) from 1.75.0 to 1.85.0.
Background
Many dependent libraries have raised their MSRV requirements, making them incompatible with our current MSRV of 1.75.0. As discussed in #315, this has been causing build failures and forcing us to use workarounds by pinning older versions of dependencies. This PR updates our MSRV to 1.85.0 to allow using current versions of these libraries.
Closes #315
Changes
This update includes:
wasm32-wasitowasm32-wasip1andwasm32-wasip2generic-arrayto 0.14.7 (see details below)generic-array Version Pin
We've pinned
generic-arrayto version 0.14.7 as a workaround for CI failures caused by warnings in v0.14.8 and later:GenericArrayin v0.14.8 causes big problem withaescreate (and probably others) fizyk20/generic-array#158elliptic-curveand related crates that remove the dependency ongeneric-array(Tracking issue for next release series RustCrypto/traits#1571)generic-arrayDetailed Changes
.github/workflows/rust.yml: Update MSRV from 1.75.0 to 1.85.0.github/workflows/wasm.yml: Replace deprecatedwasm32-wasitarget withwasm32-wasip1andwasm32-wasip2Cargo.lock: Mass dependency updatesgeneric-arraydependency to 0.14.7Test plan
🤖 Generated with Claude Code