-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSE Review - comment on Bringing it all together #80
Comments
Thank you for these helpful comments! I respond to each one below. Section: Producing Results
We have now called this section "Some pointers when performing regressions", which is much more descriptive.
Good points. The learning outcome is now rewritten as "Avoid common pitfalls when running regressions and plotting results."
Yes, there is an R implementation of the Conley HAC standard errors. I have now added a tab with this link. Section: Hands-On Exercise, Step 4
Thank you for looking at this. In addition to fixes in the underlying library, which hopefully would let you run step 3, we have also added an R implementation of step 3 using a newly developed library.
Thank you for pushing us to do this. We have now added this. It did require some hand-built code to do the state-specific trends and to calculate the confidence intervals of the dose-response function, but hopefully this will be helpful for future students.
These are good questions.
Here is the much-extended discussion in the tutorial now based on your
Great point. We have now added this paragraph:
Section: Suggestions for work organization
We have changed this to read "geospatial polygon data" to be clearer. |
Thanks for the updates. After the bulleted list in the "Running the Regression" section, there is an equation that is not rendering correctly. Please update. Major Issue: I am having some issues with the code that likely relate to my new issue in Step 3 of the Hands-On Exercise: When I try to run the regression using python, I get the following error: ValueError: exog does not have full column rank. If you wish to proceed with model estimation irrespective of the numerical accuracy of coefficient estimates, you can set check_rank=False. If I add, "check_rank=False", I get the following error: **AbsorbingEffectError: The following variables or variable combinations have been fully absorbed
Set drop_absorbed=True to automatically drop absorbed variables.** If I add "drop_absorbed=True", this still gives me the same error. I think this is related to the RunTimeError I was getting in Step 3. Please revise. Also, in the plotting section (and throughout), please revise C to deg C using Markdown as follows:
|
Here is some additional information: @ks905383 The population data has a lot of zeros and the temperature data has masked values over ocean. Also, note that when I plot the map of summer temperature (Hands-On Exercise, Step 1), there are a few spots over the US that are also missing data (figure attached) |
Ok, thanks. I will go through the code again. |
hi @ks905383, I went through all the code and redownloaded all the datasets again and now I get the right figure - yay! I can't pinpoint what the issue was, but all seems to be working well now. |
@kls2177 Thank you for going through the whole thing again. I really appreciate all the time you have spent testing this. I have also fixed the rendering of that equation. |
This Chapter nicely wraps up the tutorial. Just a few comments below.
Section: Producing Results
This section is out of my area, so I only have a few comments.
Section: Hands-On Exercise, Step 4
Section: Suggestions for work organization
The text was updated successfully, but these errors were encountered: