Skip to content

mask aws_secret_access_key in config #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2019
Merged

mask aws_secret_access_key in config #55

merged 1 commit into from
Aug 6, 2019

Conversation

mightyguava
Copy link
Contributor

so that it doesn't get printed out by fluentd on startup.

@mightyguava
Copy link
Contributor Author

I'm not entirely sure this is the correct syntax, just pattern matching from fluentd, e.g. https://github.com/fluent/fluentd/blob/351dda62a01215a49441f281b1a22783a25188a2/lib/fluent/plugin/out_forward.rb#L109

cosmo0920
cosmo0920 approved these changes Aug 6, 2019
View reviewed changes
Copy link
Collaborator

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you. 😋

@cosmo0920 cosmo0920 merged commit a80fa4d into atomita:master Aug 6, 2019
@mightyguava
Copy link
Contributor Author

Would you mind making a new release?

@cosmo0920
Copy link
Collaborator

I don't have release privileges.
@atomita Could you release a new version that includes this change?

@mishina2228 mishina2228 mentioned this pull request Oct 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mightyguava @cosmo0920