Exposes legacy properties

package.json

@@ -11,7 +11,10 @@
     "build:all": "npm run build:node && npm run build:browser",
     "install": "npm run build:node && npm run build:browser:maybe",
     "test-native": "script/test-native.js",
-    "test": "mocha test/js/*.js",
+    "test:node": "mocha test/js/*.js",
+    "test:browser": "FORCE_BROWSER_FALLBACK=1 mocha test/js/*.js",
+    "test:all": "npm run test:node && npm run test:browser",
+    "test": "npm run test:all",
     "benchmark": "node benchmark/marker-index.benchmark.js",
     "prepublish": "npm run standard",
     "standard": "standard --recursive src test",

src/bindings/em/patch.cc

@@ -36,6 +36,21 @@ Patch * deserialize(std::vector<uint8_t> const & vec)
     return new Patch(vec);
 }
 
+Point get_old_extent(Patch::Hunk const & hunk)
+{
+    return hunk.old_end.traversal(hunk.old_start);
+}
+
+Point get_new_extent(Patch::Hunk const & hunk)
+{
+    return hunk.new_end.traversal(hunk.new_start);
+}
+
+template <typename T>
+void hunk_set_noop(Patch::Hunk & hunk, T const &)
+{
+}
+
 EMSCRIPTEN_BINDINGS(Patch) {
 
     emscripten::class_<Patch>("Patch")
@@ -81,6 +96,13 @@ EMSCRIPTEN_BINDINGS(Patch) {
         .field("oldText", WRAP_FIELD(Patch::Hunk, old_text))
         .field("newText", WRAP_FIELD(Patch::Hunk, new_text))
 
+        // The following fields are legacy only (most notably, TextBuffer doesn't work without them)
+
+        .field("start", WRAP_FIELD(Patch::Hunk, new_start))
+
+        .field("oldExtent", WRAP(&get_old_extent), WRAP(&hunk_set_noop<Point>))
+        .field("newExtent", WRAP(&get_new_extent), WRAP(&hunk_set_noop<Point>))
+
         ;
 
 }

test/js/patch.test.js

@@ -34,6 +34,18 @@ describe('Patch', function () {
     patch.delete();
   })
 
+  it('expose legacy fields', function () {
+    const patch = new Patch({ mergeAdjacentHunks: false })
+
+    patch.splice({row: 0, column: 10}, {row: 0, column: 0}, {row: 1, column: 5})
+    patch.splice({row: 1, column: 5}, {row: 0, column: 2}, {row: 0, column: 8})
+
+    const hunk = patch.getHunks()[0];
+
+    assert.ok(hunk.oldExtent);
+    assert.ok(hunk.newExtent);
+  })
+
   it('honors the mergeAdjacentHunks option set to true', function () {
     const patch = new Patch({ mergeAdjacentHunks: true })