Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit df64bb5

Browse files
Explicit octal notation (#433)
1 parent 37d716c commit df64bb5

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

grammars/php.cson

+4
Original file line numberDiff line numberDiff line change
@@ -2236,6 +2236,10 @@
22362236
'match': '0[bB][01]+(?:_[01]+)*'
22372237
'name': 'constant.numeric.binary.php'
22382238
}
2239+
{
2240+
'match': '0[oO][0-7]+(?:_[0-7]+)*'
2241+
'name': 'constant.numeric.octal.php'
2242+
}
22392243
{
22402244
'match': '0(?:_?[0-7]+)+'
22412245
'name': 'constant.numeric.octal.php'

spec/php-spec.coffee

+12
Original file line numberDiff line numberDiff line change
@@ -2051,6 +2051,12 @@ describe 'PHP grammar', ->
20512051
{tokens} = grammar.tokenizeLine '0010'
20522052
expect(tokens[0]).toEqual value: '0010', scopes: ['source.php', 'constant.numeric.octal.php']
20532053

2054+
{tokens} = grammar.tokenizeLine '0o010'
2055+
expect(tokens[0]).toEqual value: '0o010', scopes: ['source.php', 'constant.numeric.octal.php']
2056+
2057+
{tokens} = grammar.tokenizeLine '0O10'
2058+
expect(tokens[0]).toEqual value: '0O10', scopes: ['source.php', 'constant.numeric.octal.php']
2059+
20542060
it 'tokenizes decimals', ->
20552061
{tokens} = grammar.tokenizeLine '1234'
20562062
expect(tokens[0]).toEqual value: '1234', scopes: ['source.php', 'constant.numeric.decimal.php']
@@ -2105,6 +2111,12 @@ describe 'PHP grammar', ->
21052111
{tokens} = grammar.tokenizeLine '0_655'
21062112
expect(tokens[0]).toEqual value: '0_655', scopes: ['source.php', 'constant.numeric.octal.php']
21072113

2114+
{tokens} = grammar.tokenizeLine '0o6_4_4'
2115+
expect(tokens[0]).toEqual value: '0o6_4_4', scopes: ['source.php', 'constant.numeric.octal.php']
2116+
2117+
{tokens} = grammar.tokenizeLine '0O6_4_4'
2118+
expect(tokens[0]).toEqual value: '0O6_4_4', scopes: ['source.php', 'constant.numeric.octal.php']
2119+
21082120
it 'tokenizes decimals', ->
21092121
{tokens} = grammar.tokenizeLine '1_234'
21102122
expect(tokens[0]).toEqual value: '1_234', scopes: ['source.php', 'constant.numeric.decimal.php']

0 commit comments

Comments
 (0)