This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Remove commit ID field from graphql query fragment #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like this won't be needed after all since review comment positions seem to be based on the diff at the time of the query, not the time of the review
Codecov Report
@@ Coverage Diff @@
## master #2003 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 189 189
Lines 11237 11237
Branches 1633 1633
=======================================
Hits 10403 10403
Misses 834 834
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field was not actually being used, and will apparently not be needed for calculating comment positioning any longer.
It also happened to be breaking our PR view due to a dotcom bug (see https://github.com/github/github/issues/109043)