This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Upgrade to Relay 3.0.0 #1982
Merged
Upgrade to Relay 3.0.0 #1982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relay 3 needs Babel 7, so it's time for us to upgrade our transpilation pipeline.
This lets us use `process.versions.electron` to magically transpile source appropriate to the actual Electron version we're running under.
winstliu
reviewed
Feb 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #1982 +/- ##
==========================================
+ Coverage 92.12% 92.13% +<.01%
==========================================
Files 188 188
Lines 10807 10803 -4
Branches 1581 1581
==========================================
- Hits 9956 9953 -3
+ Misses 851 850 -1
Continue to review full report at Codecov.
|
We need this because esprima, the JavaScript parser used by electron-link, only supports ES2017, even though our current Electron version supports some ES2018 features. Without this plugin enabled, `npm run test:snapshot` fails with an esprima error.
vanessayuenn
approved these changes
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
We're suddenly two major versions behind the latest Relay. I'm shaving all of the yaks we need to get us back in sync again - it turns out that Relay 3 requires Babel 7, so I had to get @atom/babel7-transpiler up and running first.
Screenshot/Gif
N/A
Alternate Designs
N/A
Benefits
Bug fixes and new features. Easier to patch for security vulnerabilities later if we need to.
Possible Drawbacks
It could break something else.
Applicable Issues
Fixes #1976.
Fixes #1975.
Fixes #1974.
Metrics
N/A
Tests
I'll verify with a clean test run and a quick smoke test of the GitHub tab features.
Documentation
N/A
Release Notes
N/A
User Experience Research (Optional)
N/A