Merge pull request #2222 from atom/aw/create-and-publish

Create and publish dialog

Author: smashwilson

keymaps/git.cson

@@ -112,6 +112,7 @@
   'esc': 'tool-panel:unfocus'
 
 '.github-Dialog':
+  'tab': 'core:focus-next'
   'shift-tab': 'core:focus-previous'
 
 '.github-Dialog input':
@@ -120,18 +121,20 @@
 '.github-CoAuthorForm input':
   'enter': 'core:confirm'
 
+'body .github-TabbableWrapper':
+  'down': 'github:selectbox-down'
+  'up': 'github:selectbox-up'
+  'enter': 'github:selectbox-enter'
+  'tab': 'github:selectbox-tab'
+  'backspace': 'github:selectbox-backspace'
+  'pageup': 'github:selectbox-pageup'
+  'pagedown': 'github:selectbox-pagedown'
+  'end': 'github:selectbox-end'
+  'home': 'github:selectbox-home'
+  'delete': 'github:selectbox-delete'
+  'escape': 'github:selectbox-escape'
+
 'body .github-CommitView-coAuthorEditor':
-  'enter': 'github:co-author:enter'
-  'down': 'github:co-author:down'
-  'up': 'github:co-author:up'
-  'tab': 'github:co-author:tab'
-  'backspace': 'github:co-author:backspace'
-  'escape': 'github:co-author:escape'
-  'pageup': 'github:co-author:pageup'
-  'pagedown': 'github:co-author:pagedown'
-  'home': 'github:co-author:home'
-  'end': 'github:co-author:end'
-  'delete': 'github:co-author:delete'
   'shift-backspace': 'github:co-author-exclude'
 
 '.platform-darwin .github-Reviews':

lib/atom/atom-text-editor.js

@@ -41,6 +41,7 @@ export default class AtomTextEditor extends React.Component {
     tabIndex: PropTypes.number,
 
     refModel: RefHolderPropType,
+    refElement: RefHolderPropType,
 
     children: PropTypes.node,
   }
@@ -62,7 +63,7 @@ export default class AtomTextEditor extends React.Component {
     this.subs = new CompositeDisposable();
 
     this.refParent = new RefHolder();
-    this.refElement = new RefHolder();
+    this.refElement = null;
     this.refModel = null;
   }
 
@@ -91,7 +92,7 @@ export default class AtomTextEditor extends React.Component {
       }
       element.appendChild(editor.getElement());
       this.getRefModel().setter(editor);
-      this.refElement.setter(editor.getElement());
+      this.getRefElement().setter(editor.getElement());
 
       this.subs.add(
         editor.onDidChangeCursorPosition(this.props.didChangeCursorPosition),
@@ -136,20 +137,20 @@ export default class AtomTextEditor extends React.Component {
   observeEmptiness = () => {
     this.getRefModel().map(editor => {
       if (editor.isEmpty() && this.props.hideEmptiness) {
-        this.refElement.map(element => element.classList.add(EMPTY_CLASS));
+        this.getRefElement().map(element => element.classList.add(EMPTY_CLASS));
       } else {
-        this.refElement.map(element => element.classList.remove(EMPTY_CLASS));
+        this.getRefElement().map(element => element.classList.remove(EMPTY_CLASS));
       }
       return null;
     });
   }
 
   contains(element) {
-    return this.refElement.map(e => e.contains(element)).getOr(false);
+    return this.getRefElement().map(e => e.contains(element)).getOr(false);
   }
 
   focus() {
-    this.refElement.map(e => e.focus());
+    this.getRefElement().map(e => e.focus());
   }
 
   getRefModel() {
@@ -164,6 +165,18 @@ export default class AtomTextEditor extends React.Component {
     return this.refModel;
   }
 
+  getRefElement() {
+    if (this.props.refElement) {
+      return this.props.refElement;
+    }
+
+    if (!this.refElement) {
+      this.refElement = new RefHolder();
+    }
+
+    return this.refElement;
+  }
+
   getModel() {
     return this.getRefModel().getOr(undefined);
   }