Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit 88cf835

Browse files
committed
hacking-on-atom-core.md: Update windows info
Visual Studio 2015, 2017 and 2019 are supported. Windows 8 SDK or Windows 10 SDK are supported. Clarified windows-build-tools install instructions. The latest windows-build-tools will be fine for the foreseeable future (Even when they default to Visual Studio 2019 some time soon.)
1 parent 1ba2105 commit 88cf835

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

content/hacking-atom/sections/hacking-on-atom-core.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,18 +97,18 @@ In order to build Atom from source, you need to have a number of other requireme
9797
* The `python.exe` must be available at `%SystemDrive%\Python27\python.exe`. If it is installed elsewhere create a symbolic link to the directory containing the `python.exe` using: `mklink /d %SystemDrive%\Python27 D:\elsewhere\Python27`
9898
* 7zip (7z.exe available from the command line) - for creating distribution zip files
9999
* C++ build tools, either:
100-
* [Visual C++ Build Tools 2015 or newer](https://visualstudio.microsoft.com/visual-cpp-build-tools/)
101-
* [Visual Studio 2015 or newer](https://www.visualstudio.com/downloads/) (Community Edition or better)
102-
* [windows-build-tools](https://www.npmjs.com/package/windows-build-tools): `npm install --global --production windows-build-tools@4.0`
100+
* [Visual C++ Build Tools 2015, 2017 or 2019](https://visualstudio.microsoft.com/visual-cpp-build-tools/)
101+
* [Visual Studio 2015, 2017 or 2019](https://www.visualstudio.com/downloads/) (Community Edition or better)
102+
* [windows-build-tools](https://www.npmjs.com/package/windows-build-tools) (From an elevated CMD.exe or Powershell window (right click and "run as Administrator") do: `npm install --global --production windows-build-tools` to install)
103103

104104

105105
Also ensure that:
106106

107107
* The default installation folder is chosen so the build tools can find it
108108
* If using Visual Studio make sure Visual C++ support is selected/installed
109-
* If using Visual C++ Build Tools make sure a Windows SDK is selected/installed
109+
* If using Visual C++ Build Tools make sure a Windows SDK (Windows 8 SDK or Windows 10 SDK) is selected/installed
110110
* A `git` command is in your path
111-
* Set the `GYP_MSVS_VERSION` environment variable to the Visual Studio/Build Tools version (`2015`, `2017`, etc.) e.g. ``[Environment]::SetEnvironmentVariable("GYP_MSVS_VERSION", "2015", "User")`` in PowerShell (or set it in Windows advanced system settings).
111+
* Set the `GYP_MSVS_VERSION` environment variable to the Visual Studio/Build Tools version (`2015`, `2017`, or `2019`.) e.g. ``[Environment]::SetEnvironmentVariable("GYP_MSVS_VERSION", "2015", "User")`` in PowerShell (or set it in Windows advanced system settings).
112112

113113
{{/windows}}
114114

@@ -259,7 +259,7 @@ Use [this search](https://github.com/atom/atom/search?q=label%3Abuild-error+labe
259259

260260
* `msbuild.exe failed with exit code: 1`
261261
* If using **Visual Studio**, ensure you have the **Visual C++** component installed. Go into Add/Remove Programs, select Visual Studio, press Modify, and then check the Visual C++ box.
262-
* If using **Visual C++ Build Tools**, ensure you have the **Windows 8 SDK** or **Windows 10 SDK** component installed. Go into Add/Remove Programs, select Visual C++ Build Tools, press Modify and then check the Windows 8/10 SDK box.
262+
* If using **Visual C++ Build Tools**, ensure you have the **Windows 8 SDK** or **Windows 10 SDK** component installed. Go into Add/Remove Programs, select Visual C++ Build Tools, press Modify and then check the "Windows 8 SDK" or "Windows 10 SDK" box.
263263

264264
* `script\build` stops with no error or warning shortly after displaying the versions of node, npm and Python
265265
* Make sure that the path where you have checked out Atom does not include a space. For example, use `C:\atom` instead of `C:\my stuff\atom`.
@@ -278,7 +278,7 @@ Use [this search](https://github.com/atom/atom/search?q=label%3Abuild-error+labe
278278
* See the next item.
279279

280280
* `error MSB8020: The build tools for Visual Studio 201? (Platform Toolset = 'v1?0') cannot be found.`
281-
* Try setting the `GYP_MSVS_VERSION` environment variable to **2015** or **2017** depending on what version of Visual Studio/Build Tools is installed and then `script\clean` followed by `script\build` (re-open the Command Prompt if you set the variable using the GUI).
281+
* Try setting the `GYP_MSVS_VERSION` environment variable to **2015**, **2017** or **2019** depending on what version of Visual Studio/Build Tools is installed and then `script\clean` followed by `script\build` (re-open the Command Prompt if you set the variable using the GUI).
282282

283283
* `'node-gyp' is not recognized as an internal or external command, operable program or batch file.`
284284
* Try running `npm install -g node-gyp`, and run `script\build` again.

0 commit comments

Comments
 (0)