Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest version of flowtype #37

Closed
alexreardon opened this issue Aug 16, 2017 · 8 comments
Closed

Upgrade to the latest version of flowtype #37

alexreardon opened this issue Aug 16, 2017 · 8 comments

Comments

@alexreardon
Copy link
Collaborator

Details:
https://medium.com/flow-type/even-better-support-for-react-in-flow-25b0a3485627

/cc @thejameskyle how would this change play with your prop type generator?

@jamiebuilds
Copy link

I need to rework it to lookup Props from the type parameter instead of from the class property.

@alexreardon
Copy link
Collaborator Author

alexreardon commented Aug 17, 2017

I am thinking of dropping the generating of react prop types as they are not used for any doc generation. We could always add it in later

@alexreardon
Copy link
Collaborator Author

@alexreardon
Copy link
Collaborator Author

alexreardon commented Aug 20, 2017

I tried to upgrade, but sadly I am unable to until eslint-plugin-react is fixed: jsx-eslint/eslint-plugin-react#1376

@jamiebuilds
Copy link

@alexreardon
Copy link
Collaborator Author

I think we should be good to start on this one now

@alexreardon
Copy link
Collaborator Author

I tried to upgrade today but the eslint plugin is still yet to be fixed. No harm in waiting for now

@alexreardon
Copy link
Collaborator Author

Closed by #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants