Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of auto scroll config #1205

Open
shruti8789 opened this issue Mar 28, 2019 · 6 comments
Open

Allow setting of auto scroll config #1205

shruti8789 opened this issue Mar 28, 2019 · 6 comments

Comments

@shruti8789
Copy link

Still in very early stages of fiddling around. But it is fun to play with!

early-auto-scroll

@alexreardon
Here, we can see a definite area after which it starts to auto-scroll (both above and down the pane/palette) . Can we customize this area?

Originally posted by @shruti8789 in #27 (comment)

@alexreardon
Copy link
Collaborator

What is the use case you are trying to support? Do you think there is something wrong with the existing logic? Could we improve it?

@alexreardon
Copy link
Collaborator

It feels like this issue is getting at a problem in thinking about how we auto scroll.

Here are the values we use to control auto scroll behaviour:

https://github.com/atlassian/react-beautiful-dnd/blob/master/src/state/auto-scroller/fluid-scroller/config.js

@angellindo
Copy link

@alexreardon is there a way to adjust those values to be precise the startFromPercentage

@shruti8789
Copy link
Author

@alexreardon, If you try to drag a task outside this definite area (at the start or end of the tasks visible), as soon as you will pick the task the pane will start scrolling.
Problem: If you pick a task from below the area defined after which we start scrolling, it will automatically starts to scroll down, even if the intention of the user was to drag it upwards.

@angellindo
Copy link

@shruti8789 that is correct and that is what I'm trying to avoid or reduce.

@alexreardon
Copy link
Collaborator

Perhaps we could expose a way to expose the auto scroll config

@alexreardon alexreardon changed the title Customizing area in which we auto-scroll Allow setting of auto scroll config Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants