Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle launch template latest version in observer #62

Merged
merged 2 commits into from
Jul 25, 2023
Merged

handle launch template latest version in observer #62

merged 2 commits into from
Jul 25, 2023

Conversation

Jacobious52
Copy link
Collaborator

fixes #61

  • Resolve latest launch template version before comparing
  • Test for $latest case
  • Fix issue with no logs working from the cloudprovider aws package

@Jacobious52 Jacobious52 added the bug Something isn't working label Jul 24, 2023
@Jacobious52 Jacobious52 self-assigned this Jul 24, 2023
awprice
awprice approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@awprice awprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hyang200
hyang200 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@hyang200 hyang200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jacobious52 Jacobious52 merged commit d84d128 into master Jul 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentportella vincentportella vincentportella left review comments

@awprice awprice awprice approved these changes

@hyang200 hyang200 hyang200 approved these changes

@vcatlassian vcatlassian vcatlassian approved these changes

@cespo cespo Awaiting requested review from cespo

@MinyiZ MinyiZ Awaiting requested review from MinyiZ

Assignees

@Jacobious52 Jacobious52

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Observer does not resolve $latest version of LaunchTemplate
5 participants
@Jacobious52 @awprice @vincentportella @hyang200 @vcatlassian