Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip named nodes in a CNR if they do not exist #84

Closed
vincentportella opened this issue Jul 19, 2024 · 0 comments · Fixed by #83
Closed

Skip named nodes in a CNR if they do not exist #84

vincentportella opened this issue Jul 19, 2024 · 0 comments · Fixed by #83
Assignees
@vincentportella
Labels
bug Something isn't working

Comments

@vincentportella
Copy link
Member

Describe the bug
Currently if a named node does not match an currently existing node, Cyclops will immediately fail the CNR in the Pending phase.

To Reproduce
Craft a custom CNR and add the name of a node in spec.nodeNames which does not match an currently existing node in the cluster.

Expected behavior
Cyclops should instead skip any named node that do not exist in the cluster at the time of starting to process a CNR.
@vincentportella vincentportella added the bug Something isn't working label Jul 19, 2024
@vincentportella vincentportella self-assigned this Jul 19, 2024
@vincentportella vincentportella linked a pull request Jul 19, 2024 that will close this issue
Skip named nodes in the CNR that don't exist #83
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincentportella vincentportella

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip named nodes in the CNR that don't exist atlassian-labs/cyclops
1 participant
@vincentportella