Continue to support Python 2 #1453
Conversation
|
@madscientist how about to adjust black ? :) |
Avoid Python 3-only capabilities: - Remove f-strings (jira.py, confluence.py) - Remove type specifications (bitbucket) - Remove trailing commas (bitbucket)
madscientist
force-pushed
the
pds-py2
branch
from
cb5e478
to
c5f02a3
Compare
|
Hrm, I fixed the black warnings but there's some kind of GPG key issue with the Ubuntu PPA that's now causing test failures. |
|
python2 has been deprecated 4 years ago, I don't see a good reason to keep library backwards compatibility with python2.x |
|
Well, that's up to the project of course. But currently the setup for this module says it supports Python 2, but it fails. This relatively small patch continues to support Python 2. If the project decides that they no longer want to support Python 2, then they need to modify setup.py to stop saying it does. Regardless of that, the failures in the online tests above are due to some kind of PPA key failure which has nothing to do with Python 2, and needs to be addressed before I can rerun my tests to verify the patch. Cheers! |
|
@madscientist let's continue to support python2 |
Avoid Python 3-only capabilities: