Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed confluence add_user_group to use right URL #1425

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

Mauwork
Copy link
Contributor

@Mauwork Mauwork commented Jun 26, 2024

Rel: #1422
The URL of the confluence REST API was wrong in add_user_group and it has to be a PUT request according to:

https://docs.atlassian.com/ConfluenceServer/rest/8.2.0/#api/user/{username}/group/{groupName}-update

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 34.38%. Comparing base (42ed0b0) to head (710fe28).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
atlassian/confluence.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1425   +/-   ##
=======================================
  Coverage   34.38%   34.38%           
=======================================
  Files          46       46           
  Lines        8586     8584    -2     
  Branches     1601     1601           
=======================================
  Hits         2952     2952           
+ Misses       5511     5509    -2     
  Partials      123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik gonchik merged commit 447ad1e into atlassian-api:master Aug 30, 2024
11 of 12 checks passed
@Mauwork Mauwork deleted the patch-1 branch September 6, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants