Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download attachments from page #1283

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

gkowalc
Copy link
Contributor

@gkowalc gkowalc commented Dec 12, 2023

Created new method Confluence "download_attachments_from_page". Method downloads attachments from given page id and saves them to the current directory (where the script is run) when using default path=None parameter.

It is possible to select other directory path by specifying absolute path. If custom directory doesn't exist or there is a permission error method should raise an error.

I run local tests on macos and linux hosts.

In addition to above, I also added relevant example usage and updated the docs.

@codecov-commenter
Copy link

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (3e1ef05) 34.51% compared to head (47dff27) 34.43%.

Files Patch % Lines
atlassian/confluence.py 4.34% 22 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1283      +/-   ##
==========================================
- Coverage   34.51%   34.43%   -0.09%     
==========================================
  Files          45       45              
  Lines        8184     8207      +23     
  Branches     1134     1140       +6     
==========================================
+ Hits         2825     2826       +1     
- Misses       5245     5267      +22     
  Partials      114      114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik gonchik merged commit 2a8a77f into atlassian-api:master Dec 12, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants