[Bitbucket Cloud] Add support for query parameters in pullrequest.comments endpoint #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mments endpoint Updated pull_requests.comments to accept a query string, which is passed to params if present and used with _get_paged
Updated to include the sort parameter Reorganized docstring
markarce
force-pushed
the
add_query_parameter_support_to_pullrequests_comments_endpoint
branch
from
c79e695
to
249e630
Compare
Codecov ReportBase: 36.05% // Head: 36.03% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 36.05% 36.03% -0.02%
==========================================
Files 39 39
Lines 7101 7106 +5
Branches 1022 1024 +2
==========================================
+ Hits 2560 2561 +1
- Misses 4433 4435 +2
- Partials 108 110 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
markarce
deleted the
add_query_parameter_support_to_pullrequests_comments_endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes this issue.
Updated
pull_requests.commentsto accept optional query string and sort parameters, which are added toparamsif present and used with_get_paged.Logic was copied from
PullRequests.each, which already accepts query string and sort parameters.