-
Notifications
You must be signed in to change notification settings - Fork 696
Add new createmeta functions to comply with Jira 9 API #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1031 +/- ##
==========================================
+ Coverage 35.97% 36.17% +0.20%
==========================================
Files 35 39 +4
Lines 6783 6910 +127
Branches 1058 1073 +15
==========================================
+ Hits 2440 2500 +60
- Misses 4237 4303 +66
- Partials 106 107 +1 ☔ View full report in Codecov by Sentry. |
atlassian/jira.py
Outdated
@@ -1,6 +1,8 @@ | |||
# coding=utf-8 | |||
import logging | |||
import re | |||
from typing import Union |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does that dependency typing is built-in ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typing is built into python 3, shouldn't be an issue if it's included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we have still python2 clients ;(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add python2 to the ci, as right now it only contains python 3. Rolled back the typing changes here: e8babc0 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main idea is remove python2 support, but time to time I receive emails ;)
That's why I have mentioned ;)
* Add new functions to replace deprecated stuff * run black * remove typing and use resource_url * run black
@Ry-DS please see my comment here: pycontribs/jira#1527 (comment) It looks like cloud Jira and Jira DC/Server have independent REST API and any client connecting to it should account for potential differences. Cloud JIRA still uses the (you don't need to act on this, but since I used your PR as reference on how to implement the support in |
@pmilosev thanks for that mention. |
This PR closes #1030
Adds new functions to maintain the same level of functionality, while also adding a deprecation warning for the old function.
To learn more about why this is needed, check out https://confluence.atlassian.com/jiracore/createmeta-rest-endpoint-to-be-removed-975040986.html
TODO:
self.resource_url
function for consistency's sake