Skip to content

Commit b24f7db

Browse files
Pin to importlib-metadata==4.13.0, because it's not supported in Python3.7 - Tests are failing (#1058)
Although it's in the requirements-dev.txt it's not used in flake8, bandit or doc8 Signed-off-by: Martyn <martyn.bristow@thermofisher.com> Signed-off-by: Martyn <martyn.bristow@thermofisher.com> Co-authored-by: Martyn <martyn.bristow@thermofisher.com>
1 parent 617bfde commit b24f7db

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

requirements-dev.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ python-magic
1313

1414
# On October 4, 2022 importlib-metadata released importlib-metadata 5.0.0 and in version 5.0.0
1515
# They have Deprecated EntryPoints and that's why you are facing this error.
16-
importlib-metadata==4.13.0
16+
importlib-metadata<=4.13.0

tox.ini

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ parallel_show_output = true
2121
[testenv:flake8]
2222
basepython = python3
2323
skip_install = true
24-
deps =
24+
deps =
25+
importlib-metadata<=4.13.0
2526
flake8
2627
flake8-no-fstring
2728
commands = flake8 {[base]linting_targets}
@@ -47,13 +48,16 @@ commands = mypy atlassian/
4748
[testenv:bandit]
4849
basepython = python3
4950
skip_install = true
50-
deps = bandit
51+
deps =
52+
importlib-metadata<=4.13.0
53+
bandit
5154
commands = bandit -r atlassian/
5255

5356
[testenv:doc8]
5457
basepython = python3
5558
skip_install = true
5659
deps =
60+
importlib-metadata<=4.13.0
5761
sphinx
5862
doc8
5963
commands = doc8 --ignore-path docs/_build/ docs/

0 commit comments

Comments
 (0)